Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: param enum usage example for stepaction #8605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: param enum usage example for stepaction #8605

wants to merge 1 commit into from
+18 −2

Conversation

waveywaves
Copy link
Member

Changes

add param enum usage with step action to document the usage.
fixes: #7477

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

cc @afrittoli

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 3, 2025
@tekton-robot tekton-robot requested review from dibyom and jerop March 3, 2025 10:40
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2025
@waveywaves
Copy link
Member Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 3, 2025
@waveywaves waveywaves force-pushed the stepacton-enumparam-example branch 4 times, most recently from caef34d to 6bf3aea Compare March 3, 2025 15:04
@vdemeester
Copy link
Member

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@waveywaves waveywaves force-pushed the stepacton-enumparam-example branch from 6bf3aea to fc4c668 Compare March 4, 2025 00:38
@waveywaves
Copy link
Member Author

/retest

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 11, 2025
@vdemeester
Copy link
Member

/retest

@waveywaves
chore: param enum usage example for stepaction
f46d50b 
add param enum usage with step action to document the usage.
@waveywaves waveywaves force-pushed the stepacton-enumparam-example branch from b3d176c to f46d50b Compare March 19, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@jerop jerop Awaiting requested review from jerop

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TEP-0142: Support Param Enums in StepActions
3 participants
@waveywaves @vdemeester @tekton-robot