fix: add stepaction as a valid kind in the hub resolver #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
release-note
|
/kind bug |
tekton-robot
added
kind/bug
waveywaves
force-pushed
the
step-action-artifact-hub-resolution
branch
from
5c8232f to
5bc1e64
Compare
aThorp96
approved these changes
Mar 17, 2025
Comment on lines
+362
to
+363
| if kind != "task" && kind != "pipeline" && kind != "stepaction" { | ||
| return errors.New("kind param must be either a task, pipeline or a stepaction") |
There was a problem hiding this comment.
Optional suggestion: I like they way this was addressed in the Cluster Resolver, with a const list of supportedKinds. Any objection to following that pattern?
vdemeester
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Agreed with @aThorp96 but it could be done in a follow-up as well.
cc @afrittoli
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aThorp96, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
waveywaves
force-pushed
the
step-action-artifact-hub-resolution
branch
from
5bc1e64 to
8ee6b90
Compare
The hub resolver should consider StepAction as a valid kind. This change ensures that the controller considers a stepaction as a valid kind resolving through a hub resolver. test: validate step actions in hub resolver
waveywaves
force-pushed
the
step-action-artifact-hub-resolution
branch
from
8ee6b90 to
4419884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes #8634
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes