-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option continueAndFail on step.onError #8638
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
/test check-pr-has-kind-label |
@FaniD: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cfccfb3
to
9bd73ea
Compare
371fd3e
to
6de8538
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/kind feature |
SGTM, @FaniD can we also have an e2e tests validating that the Task is indeed failed. |
sure thing. I will work on this soonish |
Feature request
Currently
onError
for steps can be set tocontinue
orstopAndFail
. In some cases, it could be beneficial to allow thetaskRun
to continue with the rest of the steps, but eventually fail with the exitCode of a specific step. Therefore, I'm introducing the valuecontinueAndFail
.This is already discussed in the comments of issue #4485
Use case
I have a task that runs a test (step 1) and publishes a test report (step 2). I want to publish a test report even if step 1 fails and let the taskRun fail accordingly (step 1 exitCode).
In that case, none of the current values of onError are enough, as
continue
would make the taskRun succeed andstopAndFail
would prevent step 2 from running.Release Notes