Skip to content

ConfigMap as a ValueSource in Param in TaskRuns and PipelineRuns #8642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
340 changes: 330 additions & 10 deletions config/300-crds/300-pipeline.yaml

Large diffs are not rendered by default.

76 changes: 74 additions & 2 deletions config/300-crds/300-pipelinerun.yaml
Original file line number Diff line number Diff line change
@@ -2589,6 +2589,8 @@ spec:
type: boolean
enableStepActions:
type: boolean
enableValueFromInParam:
type: boolean
enforceNonfalsifiability:
type: string
maxResultSize:
@@ -3003,6 +3005,8 @@ spec:
type: boolean
enableStepActions:
type: boolean
enableValueFromInParam:
type: boolean
enforceNonfalsifiability:
type: string
maxResultSize:
@@ -3291,6 +3295,8 @@ spec:
type: boolean
enableStepActions:
type: boolean
enableValueFromInParam:
type: boolean
enforceNonfalsifiability:
type: string
maxResultSize:
@@ -3523,12 +3529,44 @@ spec:
type: object
required:
- name
- value
properties:
name:
type: string
value:
description: |-
If the `enable-valuefrom-in-param` feature flag is not enabled, this field is manadatory
If the `enable-valuefrom-in-param` feature flag is enabled, exactly one of Value or ValueFrom (not both) must be defined by the user
x-kubernetes-preserve-unknown-fields: true
valueFrom:
description: |-
Available only with the `enable-valuefrom-in-param` feature flag
Exactly one of the Value and ValueFrom (not both) fields must be defined by the user
ValueFrom represents a source for the value of a parameter
The value will be obtained from the source during the TaskRun or PipelineRun initialization
type: object
properties:
configMapKeyRef:
description: Selects a key from a ConfigMap.
type: object
required:
- key
properties:
key:
description: The key to select.
type: string
name:
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
default: ""
optional:
description: Specify whether the ConfigMap or its key must be defined
type: boolean
x-kubernetes-map-type: atomic
x-kubernetes-list-type: atomic
pipelineRef:
description: PipelineRef can be used to refer to a specific instance of a Pipeline.
@@ -3552,12 +3590,44 @@ spec:
type: object
required:
- name
- value
properties:
name:
type: string
value:
description: |-
If the `enable-valuefrom-in-param` feature flag is not enabled, this field is manadatory
If the `enable-valuefrom-in-param` feature flag is enabled, exactly one of Value or ValueFrom (not both) must be defined by the user
x-kubernetes-preserve-unknown-fields: true
valueFrom:
description: |-
Available only with the `enable-valuefrom-in-param` feature flag
Exactly one of the Value and ValueFrom (not both) fields must be defined by the user
ValueFrom represents a source for the value of a parameter
The value will be obtained from the source during the TaskRun or PipelineRun initialization
type: object
properties:
configMapKeyRef:
description: Selects a key from a ConfigMap.
type: object
required:
- key
properties:
key:
description: The key to select.
type: string
name:
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
default: ""
optional:
description: Specify whether the ConfigMap or its key must be defined
type: boolean
x-kubernetes-map-type: atomic
x-kubernetes-list-type: atomic
resolver:
description: |-
@@ -5900,6 +5970,8 @@ spec:
type: boolean
enableStepActions:
type: boolean
enableValueFromInParam:
type: boolean
enforceNonfalsifiability:
type: string
maxResultSize:
34 changes: 33 additions & 1 deletion config/300-crds/300-resolutionrequest.yaml
Original file line number Diff line number Diff line change
@@ -197,12 +197,44 @@ spec:
type: object
required:
- name
- value
properties:
name:
type: string
value:
description: |-
If the `enable-valuefrom-in-param` feature flag is not enabled, this field is manadatory
If the `enable-valuefrom-in-param` feature flag is enabled, exactly one of Value or ValueFrom (not both) must be defined by the user
x-kubernetes-preserve-unknown-fields: true
valueFrom:
description: |-
Available only with the `enable-valuefrom-in-param` feature flag
Exactly one of the Value and ValueFrom (not both) fields must be defined by the user
ValueFrom represents a source for the value of a parameter
The value will be obtained from the source during the TaskRun or PipelineRun initialization
type: object
properties:
configMapKeyRef:
description: Selects a key from a ConfigMap.
type: object
required:
- key
properties:
key:
description: The key to select.
type: string
name:
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
default: ""
optional:
description: Specify whether the ConfigMap or its key must be defined
type: boolean
x-kubernetes-map-type: atomic
x-kubernetes-list-type: atomic
url:
description: |-
68 changes: 66 additions & 2 deletions config/300-crds/300-task.yaml
Original file line number Diff line number Diff line change
@@ -6823,12 +6823,44 @@ spec:
type: object
required:
- name
- value
properties:
name:
type: string
value:
description: |-
If the `enable-valuefrom-in-param` feature flag is not enabled, this field is manadatory
If the `enable-valuefrom-in-param` feature flag is enabled, exactly one of Value or ValueFrom (not both) must be defined by the user
x-kubernetes-preserve-unknown-fields: true
valueFrom:
description: |-
Available only with the `enable-valuefrom-in-param` feature flag
Exactly one of the Value and ValueFrom (not both) fields must be defined by the user
ValueFrom represents a source for the value of a parameter
The value will be obtained from the source during the TaskRun or PipelineRun initialization
type: object
properties:
configMapKeyRef:
description: Selects a key from a ConfigMap.
type: object
required:
- key
properties:
key:
description: The key to select.
type: string
name:
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
default: ""
optional:
description: Specify whether the ConfigMap or its key must be defined
type: boolean
x-kubernetes-map-type: atomic
x-kubernetes-list-type: atomic
ref:
description: Contains the reference to an existing StepAction.
@@ -6849,12 +6881,44 @@ spec:
type: object
required:
- name
- value
properties:
name:
type: string
value:
description: |-
If the `enable-valuefrom-in-param` feature flag is not enabled, this field is manadatory
If the `enable-valuefrom-in-param` feature flag is enabled, exactly one of Value or ValueFrom (not both) must be defined by the user
x-kubernetes-preserve-unknown-fields: true
valueFrom:
description: |-
Available only with the `enable-valuefrom-in-param` feature flag
Exactly one of the Value and ValueFrom (not both) fields must be defined by the user
ValueFrom represents a source for the value of a parameter
The value will be obtained from the source during the TaskRun or PipelineRun initialization
type: object
properties:
configMapKeyRef:
description: Selects a key from a ConfigMap.
type: object
required:
- key
properties:
key:
description: The key to select.
type: string
name:
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
default: ""
optional:
description: Specify whether the ConfigMap or its key must be defined
type: boolean
x-kubernetes-map-type: atomic
x-kubernetes-list-type: atomic
resolver:
description: |-
Loading