Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support passing clock during RunStatus initialization #8656

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devholic
Copy link
Contributor

@devholic devholic commented Mar 18, 2025

Changes

Currently, the TaskRunStatus/CustomRunStatus implementation did not allow passing a clock when initializing conditions, making it difficult to test and set arbitrary time values.

This commit updates the InitializeConditions method of TaskRunStatus/CustomRunStatus to accept a clock as an argument, allowing the start time to be set using the provided clock.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: The `InitializeConditions` method for `CustomRun` and `TaskRun` conditions now requires a `clock.PassiveClock` as an argument. If you are implementing a `CustomTask` controller, ensure that you pass a `clock` when invoking `InitializeConditions` for `CustomRun`.

Currently, the TaskRunStatus/CustomRunStatus implementation did not
allow passing a clock when initializing conditions, making it difficult
to test and set arbitrary time values.

This commit updates the InitializeConditions method of
TaskRunStatus/CustomRunStatus to accept a clock as an argument,
allowing the start time to be set using the provided clock.

Signed-off-by: Sunghoon Kang <[email protected]>
@tekton-robot tekton-robot added the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Mar 18, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wlynch after the PR has been reviewed.
You can assign the PR to them by writing /assign @wlynch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devholic
Copy link
Contributor Author

/kind misc

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Mar 18, 2025
@devholic
Copy link
Contributor Author

/assign @wlynch

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/run/v1beta1/customrunstatus_types.go 17.6% 55.9% 38.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants