Skip to content

fix: fix %w formatting leak in user-facing error #9003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

fix: fix %w formatting leak in user-facing error #9003

merged 1 commit into from
Oct 11, 2025

Conversation

yuzichen12123
Copy link
Contributor

Changes

See: #9002

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 2, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 2, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yuzichen12123 / name: yzc (de145a8)

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2025
@l-qing
Copy link
Member

l-qing commented Sep 2, 2025

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 2, 2025
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@afrittoli
Copy link
Member

/retest

1 similar comment
@waveywaves
Copy link
Member

/retest

@yuzichen12123 yuzichen12123 force-pushed the fix/format-error-in-printf branch from 1b2933f to e73c04c Compare September 14, 2025 15:12
@yuzichen12123
Copy link
Contributor Author

I performed a rebase.

@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2025
@yuzichen12123
Copy link
Contributor Author

/retest

1 similar comment
@l-qing
Copy link
Member

l-qing commented Sep 15, 2025

/retest

@yuzichen12123 yuzichen12123 reopened this Sep 15, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Sep 15, 2025
@l-qing
Copy link
Member

l-qing commented Sep 15, 2025

/ok-to-test

@yuzichen12123
Copy link
Contributor Author

@afrittoli @waveywaves The workflows for the current PR cannot run ("This workflow requires approval from a maintainer.").
Could you please take a look? Thanks!

@waveywaves
Copy link
Member

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l-qing, vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vdemeester,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzichen12123
Copy link
Contributor Author

@waveywaves The workflows still aren’t working as expected. Could you please take a look :)

@yuzichen12123
Copy link
Contributor Author

/retest

3 similar comments
@l-qing
Copy link
Member

l-qing commented Sep 22, 2025

/retest

@waveywaves
Copy link
Member

/retest

@vdemeester
Copy link
Member

/retest

@vdemeester
Copy link
Member

@yuzichen12123 can you rebase on top of main, just to be sure ?

@vdemeester vdemeester force-pushed the fix/format-error-in-printf branch from e73c04c to de145a8 Compare October 10, 2025 08:39
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2025
@vdemeester vdemeester added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 10, 2025
@yuzichen12123
Copy link
Contributor Author

@vdemeester Perhaps we need to retry the failed workflows.

@afrittoli
Copy link
Member

/retest

@tekton-robot tekton-robot merged commit b8ca19d into tektoncd:main Oct 11, 2025
41 of 45 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waveywaves waveywaves waveywaves approved these changes

@abayer abayer Awaiting requested review from abayer

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

+1 more reviewer

@l-qing l-qing l-qing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vdemeester vdemeester

@afrittoli afrittoli

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yuzichen12123 @l-qing @afrittoli @waveywaves @tekton-robot @vdemeester