Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency url-parse to 1.5.9 [security] #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2021

Mend Renovate

This PR contains the following updates:

Package Change
url-parse 1.4.7 -> 1.5.9

GitHub Vulnerability Alerts

CVE-2021-27515

url-parse before 1.5.0 mishandles certain uses of backslash such as http:/ and interprets the URI as a relative path.

CVE-2021-3664

Overview

Affected versions of npm url-parse are vulnerable to URL Redirection to Untrusted Site.

Impact

Depending on library usage and attacker intent, impacts may include allow/block list bypasses, SSRF attacks, open redirects, or other undesired behavior.

CVE-2022-0512

Authorization Bypass Through User-Controlled Key in NPM url-parse prior to 1.5.6.

CVE-2022-0639

A specially crafted URL with an '@​' sign but empty user info and no hostname, when parsed with url-parse, url-parse will return the incorrect href. In particular,

parse(\"http://@​/127.0.0.1\")

Will return:

{
 slashes: true,
 protocol: 'http:',
 hash: '',
 query: '',
 pathname: '/127.0.0.1',
 auth: '',
 host: '',
 port: '',
 hostname: '',
 password: '',
 username: '',
 origin: 'null',
 href: 'http:///127.0.0.1'
 }

If the 'hostname' or 'origin' attributes of the output from url-parse are used in security decisions and the final 'href' attribute of the output is then used to make a request, the decision may be incorrect.

CVE-2022-0686

url-parse prior to version 1.5.8 is vulnerable to Authorization Bypass Through User-Controlled Key.

CVE-2022-0691

Leading control characters in a URL are not stripped when passed into url-parse. This can cause input URLs to be mistakenly be interpreted as a relative URL without a hostname and protocol, while the WHATWG URL parser will trim control characters and treat it as an absolute URL.

If url-parse is used in security decisions involving the hostname / protocol, and the input URL is used in a client which uses the WHATWG URL parser, the decision may be incorrect.

This can also lead to a cross-site scripting (XSS) vulnerability if url-parse is used to check for the javascript: protocol in URLs. See following example:

const parse = require('url-parse')
const express = require('express')
const app = express()
const port = 3000

url = parse(\"\\bjavascript:alert(1)\")

console.log(url)

app.get('/', (req, res) => {
 if (url.protocol !== \"javascript:\") {res.send(\"<a href=\\'\" + url.href + \"\\'>CLICK ME!</a>\")}
 })

app.listen(port, () => {
 console.log(`Example app listening on port ${port}`)
 })

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies label May 7, 2021
@TDSBot
Copy link

TDSBot commented May 7, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot changed the title chore(deps): update dependency url-parse to 1.5.0 [security] chore(deps): update dependency url-parse to 1.5.0 [security] - autoclosed May 26, 2021
@renovate renovate bot closed this May 26, 2021
@renovate renovate bot deleted the renovate/npm-url-parse-vulnerability branch May 26, 2021 20:15
@renovate renovate bot changed the title chore(deps): update dependency url-parse to 1.5.0 [security] - autoclosed chore(deps): update dependency url-parse to 1.5.0 [security] May 26, 2021
@renovate renovate bot reopened this May 26, 2021
@renovate renovate bot restored the renovate/npm-url-parse-vulnerability branch May 26, 2021 23:55
@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 7bf7c38 to 5cc8696 Compare May 26, 2021 23:58
@TDSBot
Copy link

TDSBot commented May 27, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 5cc8696 to 1bd9742 Compare June 4, 2021 23:29
@TDSBot
Copy link

TDSBot commented Jun 4, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 1bd9742 to 1bec016 Compare June 9, 2021 01:20
@TDSBot
Copy link

TDSBot commented Jun 9, 2021

Packages pending updates:

- @tds/community-optimize-image: 1.0.1 => 1.1.0

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 1bec016 to a4baf3a Compare June 10, 2021 19:31
@TDSBot
Copy link

TDSBot commented Jun 10, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from a4baf3a to 9283907 Compare June 22, 2021 18:09
@TDSBot
Copy link

TDSBot commented Jun 22, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 9283907 to c3d9e95 Compare June 28, 2021 18:46
@TDSBot
Copy link

TDSBot commented Jun 28, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from c3d9e95 to df39263 Compare June 29, 2021 21:22
@TDSBot
Copy link

TDSBot commented Jun 29, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from df39263 to 5d4aca7 Compare June 30, 2021 20:06
@TDSBot
Copy link

TDSBot commented Jun 30, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 5d4aca7 to 9fda48d Compare July 13, 2021 22:07
@TDSBot
Copy link

TDSBot commented Jul 13, 2021

Packages pending updates:

- @tds/community-mini-expand-collapse: 0.2.0 => 0.2.1

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 9fda48d to 1508dc7 Compare July 14, 2021 21:56
@TDSBot
Copy link

TDSBot commented Jul 14, 2021

Packages pending updates:

- @tds/community-mini-expand-collapse: 0.2.0 => 0.2.1
- @tds/community-ribbon: 1.0.4 => 1.1.0

If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 1508dc7 to fb94982 Compare July 15, 2021 00:01
@TDSBot
Copy link

TDSBot commented Jul 15, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from fb94982 to 352ed5e Compare July 20, 2021 17:28
@TDSBot
Copy link

TDSBot commented Jul 20, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 352ed5e to fff2e6b Compare July 21, 2021 17:43
@TDSBot
Copy link

TDSBot commented Jul 21, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from fff2e6b to 1316da0 Compare August 31, 2021 12:54
@TDSBot
Copy link

TDSBot commented Aug 31, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 1316da0 to 84485a8 Compare September 9, 2021 22:11
@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 84485a8 to d6a3859 Compare September 21, 2021 22:35
@renovate renovate bot changed the title chore(deps): update dependency url-parse to 1.5.0 [security] chore(deps): update dependency url-parse to 1.5.2 [security] Sep 21, 2021
@TDSBot
Copy link

TDSBot commented Sep 21, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from d6a3859 to 4319740 Compare October 13, 2021 23:52
@TDSBot
Copy link

TDSBot commented Oct 13, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 4319740 to 84c623c Compare October 19, 2021 08:52
@TDSBot
Copy link

TDSBot commented Oct 19, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 84c623c to 008c31b Compare October 22, 2021 01:37
@TDSBot
Copy link

TDSBot commented Oct 22, 2021

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 008c31b to a2aa934 Compare March 8, 2022 01:23
@renovate renovate bot changed the title chore(deps): update dependency url-parse to 1.5.2 [security] chore(deps): update dependency url-parse to 1.5.9 [security] Mar 8, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Mar 8, 2022

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: This package is broken and no longer maintained. 'mkdirp' itself supports promises now, please switch to that.
npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.

lerna notice cli v3.22.1
lerna info versioning independent
lerna notice cli v3.22.1
lerna info versioning independent
lerna info Bootstrapping 25 packages
lerna info Installing external dependencies
lerna ERR! npm install --ignore-scripts --ignore-scripts --no-audit --package-lock-only exited 1 in '@tds/community-skeleton-provider'
lerna ERR! npm install --ignore-scripts --ignore-scripts --no-audit --package-lock-only stderr:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @tds/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"^16.8.2 || ^17.0.0" from the root project
npm ERR!   peer react@"^16.8.2 || ^17.0.0" from @tds/[email protected]
npm ERR!   node_modules/@tds/core-heading
npm ERR!     peer @tds/core-heading@"^2.2.5 || ^3.1.0" from the root project
npm ERR!   4 more (react-dom, styled-components, @tds/core-image, @tds/core-text)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! recompose@"^0.30.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from [email protected]
npm ERR!   node_modules/recompose
npm ERR!     recompose@"^0.30.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-04-12T01_14_38_154Z-debug-0.log

lerna ERR! npm install --ignore-scripts --ignore-scripts --no-audit --package-lock-only exited 1 in '@tds/community-skeleton-provider'

@TDSBot
Copy link

TDSBot commented Mar 8, 2022

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

@renovate renovate bot changed the title chore(deps): update dependency url-parse to 1.5.9 [security] chore(deps): update dependency url-parse to 1.5.9 [security] - autoclosed Mar 12, 2022
@renovate renovate bot closed this Mar 12, 2022
@renovate renovate bot deleted the renovate/npm-url-parse-vulnerability branch March 12, 2022 00:43
@renovate renovate bot changed the title chore(deps): update dependency url-parse to 1.5.9 [security] - autoclosed chore(deps): update dependency url-parse to 1.5.9 [security] Mar 16, 2022
@renovate renovate bot reopened this Mar 16, 2022
@renovate renovate bot restored the renovate/npm-url-parse-vulnerability branch March 16, 2022 00:11
@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from a2aa934 to 3713f72 Compare April 12, 2022 01:14
@github-actions
Copy link

Packages pending updates:


If this is not what you expected, ensure that your commit messages follow the TDS commit types guide on this page: https://tds.telus.com/contributing/developer-guide.html and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants