Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go SDK and update Nexus sample #389

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Feb 11, 2025

Also upgrade the API dependency in the grpc-proxy sample

DO NOT MERGE - this is still pending the Go SDK release.

Also upgrade the API dependency in the grpc-proxy sample
@@ -15,10 +15,11 @@ import (
)

// NewSyncOperation is a meant for exposing simple RPC handlers.
var EchoOperation = temporalnexus.NewSyncOperation(service.EchoOperationName, func(ctx context.Context, c client.Client, input service.EchoInput, options nexus.StartOperationOptions) (service.EchoOutput, error) {
var EchoOperation = nexus.NewSyncOperation(service.EchoOperationName, func(ctx context.Context, input service.EchoInput, options nexus.StartOperationOptions) (service.EchoOutput, error) {
// The method is provided with an SDK client that can be used for arbitrary calls such as signaling, querying,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment no longer makes sense since the method does not provide a client

@@ -24,16 +24,14 @@ This sample shows how to use Temporal for authoring a Nexus service and call it
site](https://learn.temporal.io/getting_started/go/dev_environment/#set-up-a-local-temporal-service-for-development-with-temporal-cli)
to install Temporal CLI.

> NOTE: Required version is at least v1.1.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to recommend v1.3.0 (I am assuming that will be the latest release and include all the GA changes)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating that but didn't want to be too strict. Rethinking that I think it's probably the best to recommend the latest and greatest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we merge temporalio/sdk-go#1833 we should only be recommending a server release that understands this error shouldn't be retryable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the recommendation.

@bergundy bergundy marked this pull request as ready for review February 26, 2025 00:53
@bergundy bergundy enabled auto-merge (squash) February 26, 2025 00:55
@bergundy bergundy merged commit 5d3e785 into temporalio:main Feb 26, 2025
3 checks passed
@bergundy bergundy deleted the nexus-0.2.0 branch February 26, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants