Upgrade Go SDK and update Nexus sample #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade the API dependency in the grpc-proxy sample
Quinn-With-Two-Ns
approved these changes
Feb 11, 2025
nexus/handler/app.go
Outdated
| @@ -15,10 +15,11 @@ import ( | |||
| ) | |||
|
|
|||
| // NewSyncOperation is a meant for exposing simple RPC handlers. | |||
| var EchoOperation = temporalnexus.NewSyncOperation(service.EchoOperationName, func(ctx context.Context, c client.Client, input service.EchoInput, options nexus.StartOperationOptions) (service.EchoOutput, error) { | |||
| var EchoOperation = nexus.NewSyncOperation(service.EchoOperationName, func(ctx context.Context, input service.EchoInput, options nexus.StartOperationOptions) (service.EchoOutput, error) { | |||
| // The method is provided with an SDK client that can be used for arbitrary calls such as signaling, querying, | |||
There was a problem hiding this comment.
This comment no longer makes sense since the method does not provide a client
| @@ -24,16 +24,14 @@ This sample shows how to use Temporal for authoring a Nexus service and call it | |||
| site](https://learn.temporal.io/getting_started/go/dev_environment/#set-up-a-local-temporal-service-for-development-with-temporal-cli) | |||
| to install Temporal CLI. | |||
|
|
|||
| > NOTE: Required version is at least v1.1.0. | |||
There was a problem hiding this comment.
Do we want to recommend v1.3.0 (I am assuming that will be the latest release and include all the GA changes)
There was a problem hiding this comment.
I was debating that but didn't want to be too strict. Rethinking that I think it's probably the best to recommend the latest and greatest.
There was a problem hiding this comment.
I think if we merge temporalio/sdk-go#1833 we should only be recommending a server release that understands this error shouldn't be retryable
There was a problem hiding this comment.
Updated the recommendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade the API dependency in the grpc-proxy sample
DO NOT MERGE - this is still pending the Go SDK release.