-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go SDK and update Nexus sample #389
Conversation
Also upgrade the API dependency in the grpc-proxy sample
nexus/handler/app.go
Outdated
@@ -15,10 +15,11 @@ import ( | |||
) | |||
|
|||
// NewSyncOperation is a meant for exposing simple RPC handlers. | |||
var EchoOperation = temporalnexus.NewSyncOperation(service.EchoOperationName, func(ctx context.Context, c client.Client, input service.EchoInput, options nexus.StartOperationOptions) (service.EchoOutput, error) { | |||
var EchoOperation = nexus.NewSyncOperation(service.EchoOperationName, func(ctx context.Context, input service.EchoInput, options nexus.StartOperationOptions) (service.EchoOutput, error) { | |||
// The method is provided with an SDK client that can be used for arbitrary calls such as signaling, querying, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment no longer makes sense since the method does not provide a client
@@ -24,16 +24,14 @@ This sample shows how to use Temporal for authoring a Nexus service and call it | |||
site](https://learn.temporal.io/getting_started/go/dev_environment/#set-up-a-local-temporal-service-for-development-with-temporal-cli) | |||
to install Temporal CLI. | |||
|
|||
> NOTE: Required version is at least v1.1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to recommend v1.3.0
(I am assuming that will be the latest release and include all the GA changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was debating that but didn't want to be too strict. Rethinking that I think it's probably the best to recommend the latest and greatest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we merge temporalio/sdk-go#1833 we should only be recommending a server release that understands this error shouldn't be retryable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the recommendation.
Also upgrade the API dependency in the grpc-proxy sample
DO NOT MERGE - this is still pending the Go SDK release.