Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus SyncOperation context propagation #395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bergundy
Copy link
Member

No description provided.

// Values may be extracted from the context in the Operation handler body.
values, ok := ctx.Value(ctxpropagation.PropagateKey).(ctxpropagation.Values)
if ok {
input.Message += ", " + values.Key + ": " + values.Value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just log the context value, we generally using headers to pass input

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion, do you think it's worth blocking the PR for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are samples should reflect what we recommend users do in production. Maxim has called out our samples that do things we wouldn't recommend users do in production so yes I think we should change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants