Nexus SyncOperation context propagation #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Values may be extracted from the context in the Operation handler body. | ||
| values, ok := ctx.Value(ctxpropagation.PropagateKey).(ctxpropagation.Values) | ||
| if ok { | ||
| input.Message += ", " + values.Key + ": " + values.Value |
There was a problem hiding this comment.
We could just log the context value, we generally using headers to pass input
There was a problem hiding this comment.
I don't have a strong opinion, do you think it's worth blocking the PR for this?
There was a problem hiding this comment.
Are samples should reflect what we recommend users do in production. Maxim has called out our samples that do things we wouldn't recommend users do in production so yes I think we should change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.