-
Notifications
You must be signed in to change notification settings - Fork 89
Workflow/Activity Priorities #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
10082a7
80a9e4f
386dad7
6dca0e6
ac33dbd
050562d
11f83e5
e4bbd54
43b9aed
0b29b9c
78e3089
96730dc
6e6b45d
ced8749
9060804
ee03543
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,15 @@ | ||
FROM python:3.10 | ||
|
||
RUN curl -LsSf https://astral.sh/uv/install.sh | sh | ||
ENV PATH="$PATH:/root/.local/bin" | ||
RUN uv tool install poethepoet | ||
VOLUME ["/api_new", "/bridge_new"] | ||
|
||
COPY ./ ./ | ||
|
||
RUN mkdir -p ./temporalio/api | ||
RUN uv sync --all-extras | ||
RUN uv add "protobuf<4" | ||
RUN uv sync --all-extras | ||
RUN poe gen-protos | ||
|
||
CMD cp -r ./temporalio/api/* /api_new && cp -r ./temporalio/bridge/proto/* /bridge_new |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -116,6 +116,7 @@ class Info: | |
workflow_namespace: str | ||
workflow_run_id: str | ||
workflow_type: str | ||
priority: temporalio.common.Priority | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is priority always non-null in proto for activity task and workflow start event? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, it's not, but we decided that just means default. Not personally a huge fan of that, but, the information conveyed is the same temporalio/sdk-java#2453 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Works for me. When it comes to us passing it in, does server care whether we send a null priority or a non-null one with default values? The reason I ask about that direction is because if we want always output to be non- |
||
# TODO(cretz): Consider putting identity on here for "worker_id" for logger? | ||
|
||
def _logger_details(self) -> Mapping[str, Any]: | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete line 11 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProbablyYes