Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent error output from passing test #804

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

dandavison
Copy link
Contributor

Prevent error ouptut from test. See #801 (comment)

tests/worker/test_update_with_start.py .

================================================================================================= 1 passed in 0.54s ==================================================================================================
Future exception was never retrieved
future: <Future finished exception=RPCError('empty details')>
Traceback (most recent call last):
  File "/Users/dan/src/temporalio/sdk-python/tests/worker/test_update_with_start.py", line 843, in test_start_update_with_start_empty_details
    await client.start_update_with_start_workflow(
  File "/Users/dan/src/temporalio/sdk-python/temporalio/client.py", line 1048, in start_update_with_start_workflow
    return await self._start_update_with_start(
  File "/Users/dan/src/temporalio/sdk-python/temporalio/client.py", line 1120, in _start_update_with_start
    return await self._impl.start_update_with_start_workflow(input)
  File "/Users/dan/src/temporalio/sdk-python/temporalio/client.py", line 6113, in start_update_with_start_workflow
    raise err
  File "/Users/dan/src/temporalio/sdk-python/temporalio/client.py", line 6059, in start_update_with_start_workflow
    return await self._start_workflow_update_with_start(
  File "/Users/dan/src/temporalio/sdk-python/temporalio/client.py", line 6149, in _start_workflow_update_with_start
    await self._client.workflow_service.execute_multi_operation(multiop_req)
  File "/Users/dan/src/temporalio/sdk-python/tests/worker/test_update_with_start.py", line 836, in __call__
    raise self.empty_details_err
temporalio.service.RPCError: empty details

@dandavison dandavison requested a review from a team as a code owner March 27, 2025 22:31
@dandavison dandavison changed the title Prevent error ouptut from passing test Prevent error output from passing test Mar 27, 2025
@dandavison dandavison requested a review from THardy98 March 27, 2025 22:32
Copy link
Contributor

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dandavison dandavison merged commit 65b10bf into main Mar 28, 2025
14 checks passed
@dandavison dandavison deleted the fix_update_index_error_dan branch March 28, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants