Move timeout default from schedule_to_close to start_to_close #969
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jul 15, 2025
| """Maximum time from scheduling to completion.""" | ||
|
|
||
| schedule_to_start_timeout: Optional[timedelta] = None | ||
| """Maximum time from scheduling to starting.""" | ||
|
|
||
| start_to_close_timeout: Optional[timedelta] = None | ||
| start_to_close_timeout: Optional[timedelta] = timedelta(seconds=60) |
There was a problem hiding this comment.
IMO we should not do this until we are also properly differentiating retryable vs non-retryable errors on the model activity. If someone has an auth failure, it will now retry forever. Can we except-and-re-raise model activity failures as application error properly accounting for what is retryable and what's not (basically 4xx HTTP is non-retryable, 5xx is retryable, or some variant of that logic)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: