Skip to content

Fixing OpenAI tracing issues #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2025
Merged

Fixing OpenAI tracing issues #974

merged 9 commits into from
Jul 18, 2025

Conversation

tconley1428
Copy link
Contributor

@tconley1428 tconley1428 commented Jul 16, 2025

What was changed

Traces are not restarted across activity boundaries, span parentage is propagated across activity boundaries. Remove startActivity event

Why?

This makes the traces much more understandable

Checklist

  1. Closes Add tests for the tracing intercepter to OpenAI tests #916

  2. How was this tested:
    Validated against the tracing UI

image
  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner July 16, 2025 17:56
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to open an issue for tracking adding tests for confirming tracing works and continues to work as expected

@tconley1428 tconley1428 merged commit 60f67d9 into main Jul 18, 2025
27 of 28 checks passed
@tconley1428 tconley1428 deleted the openai/tracing_fixes branch July 18, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for the tracing intercepter to OpenAI tests
2 participants