Skip unavailable deprecated CRD watches - #469
Open
Guflly wants to merge 4 commits into
Open
Conversation
|
|
jlegrone
reviewed
Jul 28, 2026
Guflly
force-pushed
the
fix/optional-deprecated-crd-watches
branch
from
July 31, 2026 00:47
8d4c92b to
7aa75df
Compare
Guflly
force-pushed
the
fix/optional-deprecated-crd-watches
branch
from
July 31, 2026 10:57
7aa75df to
cfb79ee
Compare
jaypipes
approved these changes
Jul 31, 2026
Guflly
changed the title
jaypipes
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Checks at startup whether the deprecated
TemporalWorkerDeploymentandTemporalConnectionresources can be listed and watched in each configured namespace.If a resource is missing or access is forbidden, its deprecated reconciler and watch paths are skipped. The two resources are checked independently.
Fixes #413
Tested
go test ./internal/controller -run TestDetectDeprecatedCRDWatches -count=1go test ./internal/controller -count=1go vet ./...go build ./cmd/...golangci-lint run --build-tags test_dep --new-from-rev=HEAD~ --config=.github/.golangci.yml