Repository navigation
Fix the primary Select's text color - #4090
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
approved these changes
Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
A
Selectcomponent withvariant="primary"showed dark text on the indigo button. A primaryMenuButtonshows white text. Select added its neutral input classes (text-primary,bg-background-primaryand others) over everyvariant, and the inner
<input>always settext-primaryortext-secondary. When the menu was open, the button turned dark indigo but kept the dark text.This PR:
MenuButton's primary styles, with an indigo background and white text. The placeholder is white at 90%opacity.
Extract<ButtonStyles['variant'], 'primary' | 'secondary'>. The otherButtonvariants never worked on aSelect, because the neutral classes painted over them.focus-visible:border-secondary,focus-visible:ring-interactive-primaryanddisabled:opacity-disabledsince theButtonbase component already provides the last two, and nothing changes the border on focus.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?