Skip to content

Conversation

@struong
Copy link
Contributor

@struong struong commented Jan 1, 2026

motivation

fee-payer CI test is failing with liquidity issues. Debugged and found that a changed ABI also breaks the test. Upstream changes to viem will fix in wevm/viem#4201 but we can get CI to pass for the time being by pointing to testnet instead

change

Run pnpm test:testnet for CI tests

testing

""

Greptile Summary

Temporarily switches CI tests to use testnet instead of prool local instance to work around liquidity issues and ABI breaking changes. Once the Moderato hardfork lands in viem (wevm/viem#4201), this should be reverted to use the prool instance again.

  • Changed test command from pnpm test to pnpm test:testnet in fee-payer CI workflow
  • Added TODO comment indicating this is temporary until Moderato hardfork support lands
  • Minor style issue: TEMPO_ENV env var in workflow still set to localnet (the test script overrides this, but could cause confusion)

Confidence Score: 4/5

  • Safe temporary workaround with clear TODO for reverting once upstream fix lands
  • Simple change that switches test environment. The TODO comment makes it clear this is temporary. Only minor style issue with env var inconsistency that doesn't affect functionality.
  • No files require special attention - straightforward test environment change

Important Files Changed

Filename Overview
.github/workflows/test-fee-payer.yml Changed test command from pnpm test to pnpm test:testnet as temporary workaround for liquidity issues and ABI changes. Minor inconsistency with TEMPO_ENV env var still set to localnet.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant WF as test-fee-payer.yml
    participant PKG as package.json
    participant VC as vitest.config.ts
    participant TS as Test Suite

    GH->>WF: Trigger workflow
    WF->>WF: Set TEMPO_ENV=localnet (env var)
    WF->>PKG: Run pnpm test:testnet
    PKG->>PKG: Set TEMPO_ENV=testnet (overrides)
    PKG->>VC: Execute vitest --run
    VC->>VC: Read TEMPO_ENV=testnet
    VC->>VC: Set RPC URL to https://rpc.testnet.tempo.xyz
    VC->>VC: Skip prool local setup (line 33)
    VC->>TS: Run tests against testnet
    TS->>TS: Execute fee-payer integration tests
    TS-->>GH: Return test results
Loading

@struong struong merged commit c5192f6 into main Jan 1, 2026
5 checks passed
@struong struong deleted the struong/update-fp-ci-test branch January 1, 2026 09:10
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. .github/workflows/test-fee-payer.yml, line 20 (link)

    style: Env var still set to localnet but test command uses testnet. The test:testnet script overrides this, but for clarity consider updating this to testnet or removing it.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants