fix ps+keras without unique #488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq
force-pushed
the
ps
branch
29 times, most recently
from
a6bd824 to
9109fa8
Compare
jq
force-pushed
the
ps
branch
28 times, most recently
from
7dd7d7b to
99f2cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tfra rely on DistributedVariable to get the correct device placement i.e. ._get_on_device_or_primary method, however, this only returns device 0 under PSV2, It breaks the TFRA PS.
This PR fix it by using resource var directly without the DistributedVariable, the unique backwards computation still has problem, let's fix it in another pr
Co-authored-by: @MoFHeka
Fixes # (issue)
#182
#401
#365
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*