Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate eager and ndarray docs when releasing. #353

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

dskkato
Copy link
Contributor

@dskkato dskkato commented Apr 13, 2022

Thank you for releasing v.0.18.0 of this crate. Also, the documentation for this crate is back in #336 and users can now check it at docs.rs.

https://docs.rs/tensorflow/0.18.0/tensorflow/index.html

However, I noticed that there is no additional features when generating the documentation. Also, the docs for https://tensorflow.github.io/rust/tensorflow/ are missing the eager and ndarray feature docs.

This PR resolves the above inconsistent docs in both docs.rs and github.io.

@adamcrume
Copy link
Contributor

Thanks! This was an oversight. I wish that rustdoc would automatically indicate when additional features are required for certain items, but at least documenting it ourselves should be sufficient for now.

@adamcrume adamcrume merged commit eba84e2 into tensorflow:master Apr 13, 2022
@dskkato dskkato deleted the eager_docs branch April 13, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants