Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorBoard 2.12.0 #6192

Merged
merged 7 commits into from
Feb 9, 2023
Merged

TensorBoard 2.12.0 #6192

merged 7 commits into from
Feb 9, 2023

Conversation

arcra
Copy link
Member

@arcra arcra commented Feb 9, 2023

  • Motivation for features / changes
    The TensorBoard release that tracks the TF 2.12 release.

  • Technical description of changes

    • Fixes a test related to our "compat" proto copies to keep in sync with TF protos.
    • Updates our "compat" proto copies from the TF repo up to the branch cut commit for their release 2.12 (3e5b6f1899f8515b3f27c67b5bea7481e990c163).
    • Adds the normal release commits to:
      • pin the TF version for CI (to tf-nightly==2.12.0.dev20230201, which is the one available before the branch cut commit),
      • add release notes, and
      • bump the TB version.
  • Detailed steps to verify changes work correctly (as executed by you)
    Generated the pip package and ran it to test that it works. There is a known issue still, with the WhatIfTool plugin, which is a separate pip package that we use, and which needs to update their proto dependency as well, but to unblock the TF release, we'll deal with that later. The rest of the functionality of TB is unaffected.

@arcra arcra requested a review from nfelt February 9, 2023 21:19
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to rebase and merge - thanks! 🦀 🎉

@arcra
Copy link
Member Author

arcra commented Feb 9, 2023

As discussed in person, I removed some lines from our CI workflow where we were generating a pip package with a PEP 440 non-conforming name, which setuptools doesn't support since version 66.

That package was not used, so there are no consequences for this release.

@arcra arcra merged commit f38a9ee into tensorflow:2.12 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants