Skip to content

Add 16bit support for unpack, transpose and comparisons operators#3028

Merged
mergify[bot] merged 17 commits intotensorflow:mainfrom
rameshkunasi:main
Mar 17, 2025
Merged

Add 16bit support for unpack, transpose and comparisons operators#3028
mergify[bot] merged 17 commits intotensorflow:mainfrom
rameshkunasi:main

Conversation

@rameshkunasi
Copy link
Contributor

@rameshkunasi rameshkunasi commented Dec 24, 2024

Added 16bit operator support for below operators:

  1. unpack
  2. transpose
  3. comparison

And FC Per channel quantization support using RefC operator

BUG=fixes #3044

@rameshkunasi rameshkunasi requested a review from a team as a code owner December 24, 2024 11:04
@rameshkunasi
Copy link
Contributor Author

rameshkunasi commented Jan 16, 2025

@gonnet can you please review the updated changes

@suleshahid suleshahid added ci:full Triggers the comprehensive cross-platform test suite. and removed ci:ready_to_merge labels Feb 10, 2025
@TFLM-bot TFLM-bot removed the ci:full Triggers the comprehensive cross-platform test suite. label Feb 10, 2025
@ddavis-2015
Copy link
Member

@suleshahid No unit tests?

@ddavis-2015 ddavis-2015 self-requested a review March 4, 2025 09:16
@ddavis-2015 ddavis-2015 added the ci:full Triggers the comprehensive cross-platform test suite. label Mar 13, 2025
@TFLM-bot TFLM-bot removed the ci:full Triggers the comprehensive cross-platform test suite. label Mar 13, 2025
@ddavis-2015 ddavis-2015 added the ci:full Triggers the comprehensive cross-platform test suite. label Mar 14, 2025
@TFLM-bot TFLM-bot removed the ci:full Triggers the comprehensive cross-platform test suite. label Mar 14, 2025
…on support. Since CMSIS_NN supports per channel quantization for INT8
@ddavis-2015 ddavis-2015 added the ci:full Triggers the comprehensive cross-platform test suite. label Mar 14, 2025
@TFLM-bot TFLM-bot removed the ci:full Triggers the comprehensive cross-platform test suite. label Mar 14, 2025
@ddavis-2015
Copy link
Member

@rameshkunasi I forgot to let you know that whenever a file is updated, its copyright date must also change. Each changed file should have a current year copyright, and only a single year should appear in the copyright. Do not reformat the copyright, as there is a CI check for its format.

@ddavis-2015
Copy link
Member

@rameshkunasi !defined(HEXAGON) is needed around all per-channel quantized unit test code for FULLY_CONNECTED.

…flag of HEXAGON and copyright year changed to all modified files
@rameshkunasi
Copy link
Contributor Author

@rameshkunasi I forgot to let you know that whenever a file is updated, its copyright date must also change. Each changed file should have a current year copyright, and only a single year should appear in the copyright. Do not reformat the copyright, as there is a CI check for its format.

@ddavis-2015 Updated the changes as per your suggestions

@ddavis-2015 ddavis-2015 added the ci:full Triggers the comprehensive cross-platform test suite. label Mar 15, 2025
@TFLM-bot TFLM-bot removed the ci:full Triggers the comprehensive cross-platform test suite. label Mar 15, 2025
@ddavis-2015 ddavis-2015 added the ci:full Triggers the comprehensive cross-platform test suite. label Mar 16, 2025
@TFLM-bot TFLM-bot removed the ci:full Triggers the comprehensive cross-platform test suite. label Mar 16, 2025
Copy link
Member

@ddavis-2015 ddavis-2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. On to @suleshahid.

@mergify mergify bot merged commit 39209b4 into tensorflow:main Mar 17, 2025
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 16bit Support to unpack, transpose and comparisons and Per channel FC support

5 participants