Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System versioned tables #97

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

System versioned tables #97

wants to merge 3 commits into from

Conversation

Nefarious46
Copy link
Contributor

Regarding controller endpoint version datatype:

  • Had to use non-primitive datatype Integer to allow NULL values to be sent. Was not able to default to current timestamp with primitive int.
  • RequestParam Required=false makes the version parameter optional which allows NULL values.

Procedure tests did not have change at all since they are not affected if inserted with NULL value. (Did rearrange some test data because this time it rotated the ordering...?)

@Nefarious46 Nefarious46 added enhancement New feature or request feature Existing feature Specification Required by software specifications labels Jan 21, 2025
@Nefarious46 Nefarious46 requested a review from kortemik January 21, 2025 19:14
@Nefarious46 Nefarious46 self-assigned this Jan 21, 2025
kortemik
kortemik requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@kortemik kortemik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create an issue at least for creating a tests for api version request testing, there are no tests that test the new functionality

src/main/resources/db/migration/R__Procedure_Retrieve_All_Capture_groups.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_Retrieve_Capture_File.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_Retrieve_Capture_Group.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_Retrieve_Capture_Storages.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_Retrieve_Capture_meta.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_Retrieve_Storages.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_Retrieve_g_x_g.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/R__Procedure_transactionTest.sql Outdated Show resolved Hide resolved
src/test/java/com/teragrep/cfe18/controllerTests/TestSpringBootInformation.java Outdated Show resolved Hide resolved
src/test/resources/test.properties Outdated Show resolved Hide resolved
@StrongestNumber9 StrongestNumber9 mentioned this pull request Jan 27, 2025
Merged
@Nefarious46 Nefarious46 requested a review from kortemik January 28, 2025 11:00
@kortemik
Copy link
Member

@StrongestNumber9 merge this once quadlet version has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrongestNumber9 StrongestNumber9 StrongestNumber9 left review comments

@kortemik kortemik kortemik approved these changes

Assignees

@Nefarious46 Nefarious46

Labels
enhancement New feature or request feature Existing feature Specification Required by software specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nefarious46 @kortemik @StrongestNumber9