Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use smallest filtersize for initial buffer #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elliVM
Copy link
Contributor

@elliVM elliVM commented Nov 5, 2024

Replace small hard coded initial filter and use the smallest filter size from map.

  • If different size filters come into merge return the larger one (case when initial filter size is updated)
  • Add testing for filter size selection and missing estimate value

@elliVM elliVM self-assigned this Nov 5, 2024
@elliVM elliVM requested a review from 51-code November 5, 2024 12:55
@elliVM elliVM force-pushed the zero-buffer-smallest-filtersize branch from 04764cc to 5e67536 Compare November 5, 2024 13:15
@elliVM
Copy link
Contributor Author

elliVM commented Nov 5, 2024

rebased to main

@elliVM elliVM requested a review from 51-code November 6, 2024 13:38
Copy link

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliVM elliVM requested a review from kortemik November 7, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants