Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tests for the log outputs of liblognorm error and debug callbacks #14

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Implement tests for the log outputs of liblognorm error and debug callbacks #14

wants to merge 10 commits into from

Conversation

Tiihott
Copy link
Contributor

@Tiihott Tiihott commented Jan 15, 2025 •
edited
Loading

Includes:

  • Asserting the log outputs of liblognorm error and debug callbacks in new tests (issue Implement tests for asserting that the logging from c to java is working properly #11).
  • Moved JNA callback interfaces and implementations to separate files from main JNA interface. It was required for log assertions, and tests indicated that JNA library doesn't require them to be inside main JNA interface.
  • Added mockito and log4j dependencies for asserting callback log outputs during tests.

Not yet implemented:

  • Expanded tests

Also includes commits from PR #3, PR #5, PR #6, PR #8 and PR #13. Rebase may be needed in this PR after they have been merged to main.
New commits are f127195 and later.

@Tiihott Tiihott self-assigned this Jan 15, 2025
@Tiihott Tiihott requested a review from 51-code January 16, 2025 06:35
@Tiihott Tiihott requested a review from 51-code January 17, 2025 08:38
51-code
51-code approved these changes Jan 20, 2025
View reviewed changes
Copy link

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@kortemik
Copy link
Member

please rebase

@Tiihott Tiihott force-pushed the jna_assert_logging branch from a519ca3 to d362ce9 Compare January 28, 2025 06:43
Tiihott added 10 commits January 28, 2025 10:23
@Tiihott Tiihott force-pushed the jna_assert_logging branch from d362ce9 to 47461d6 Compare January 28, 2025 08:42
@Tiihott
Copy link
Contributor Author

Tiihott commented Jan 28, 2025

Rebased to main.

@Tiihott Tiihott requested a review from 51-code January 28, 2025 10:36
@Tiihott Tiihott mentioned this pull request Jan 28, 2025
Open
@Tiihott Tiihott linked an issue Jan 28, 2025 that may be closed by this pull request
Implement tests for asserting that the logging from c to java is working properly #11
Open
@Tiihott Tiihott requested a review from kortemik January 30, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@51-code 51-code 51-code approved these changes

@kortemik kortemik Awaiting requested review from kortemik

Assignees

@Tiihott Tiihott

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement tests for asserting that the logging from c to java is working properly
4 participants
@Tiihott @kortemik @51-code @StrongestNumber9