Skip to content

Conversation

@MarvinMonotomic
Copy link

our customers often have the request to show a progress-bar inside the form.
the plugin only supports to show the steps as a navigation.

It would be a very nice extension to give the option to show the progressbar above the page-switch buttons.

I also added a wrapper for the buttons for easier styling - but this is optional

Copy link
Member

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution!

I don't think it makes sense to have this checkbox for every single page break element. If I have 10 steps, I want the layout to always look the same, right? Why would I have to enable this checkbox 10 times? Sounds more like it would be something that I wanted to configure for every form, not for every page break element.

So I'm asking myself what problem you are trying to solve here? You can already adjust the form_mp_form_pageswitch.html5 template to your liking. Then you get your percentage output automatically without needing to check any checkbox in the backend?

PS: You are using insert tags within a template. We never use insert tags within a template because this is PHP so we can directly pass the appropriate variables. So if anything can be done, then maybe a PR that passes those values to the template so you don't have to use insert tags like you do now?

@MarvinMonotomic
Copy link
Author

Hi, thanks for your response.

I agree that a checkbox in the form itself would be more suitable.
But I also think that the checkbox is necessary here, because there are some occasions, where you only have two steps. In this case, i don't think you would need a progress-bar.

You are right, that i should not use insert-tags inside php, but i stumbled over this requirement and the insert was the fastest way to implement it.

I was interested, whether this feature is even wanted

@Toflar
Copy link
Member

Toflar commented Nov 6, 2025

In my opinion showing the progress bar or not is usually a layout decision. Not a decision the user makes. So why not just adjust your template like you did and that's it? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants