used should count terminating #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used should include terminating nodes, because their ram will migrate otherwise we get in a stupid situation where it keeps terminating, and that used disappears, so it terminates again, and then it has to create because all that stuff gets migrated back the condition wants to catch nodes that are terminating, or non-terminating and non-disabled. If they are non-terminating and disabled, then we should not count the used. (effectively nodes that are only disabled don't exist). We disable nodes that are terminating, making the condition more complicated than just always adding it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used should include terminating nodes, because their ram will migrate
otherwise we get in a stupid situation where it keeps terminating, and that used disappears, so it terminates again, and then it has to create because all that stuff gets migrated back
the condition wants to catch nodes that are terminating, or non-terminating and non-disabled. If they are non-terminating and disabled, then we should not count the used. (effectively nodes that are only disabled don't exist). We disable nodes that are terminating, making the condition more complicated than just always adding it