Skip to content

feat!: Support specifying name for OAC and Terraform MSV 1.5.7 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Jul 2, 2025

Description

Allow specifying a name for OAC instead of just using each.key.
Also to accommodate optional variable type, bump terraform MSV to 1.5.7.

Motivation and Context

Closes: #160

Breaking Changes

Yes Terraform MSV 1.5.7.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum marked this pull request as draft July 2, 2025 00:12
@magreenbaum magreenbaum changed the title feat: Support specifying name for OAC feat!: Support specifying name for OAC and Terraform MSV 1.5.7 Jul 2, 2025
@magreenbaum magreenbaum marked this pull request as ready for review July 2, 2025 00:17
@antonbabenko antonbabenko merged commit 736ce3b into terraform-aws-modules:master Jul 6, 2025
8 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 6, 2025
## [5.0.0](v4.2.0...v5.0.0) (2025-07-06)

### ⚠ BREAKING CHANGES

* Support specifying name for OAC and Terraform MSV 1.5.7 (#166)

### Features

* Support specifying name for OAC and Terraform MSV 1.5.7 ([#166](#166)) ([736ce3b](736ce3b))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.0 🎉

Copy link

github-actions bot commented Aug 6, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Allow configurable naming of origin_access_control resources using each.value['name'] with fallback to each.key
2 participants