feat: add aws_security_group_inline_rules rule #793
+225
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to decide about "enabled by default" and "severity". |
wata727
reviewed
Dec 22, 2024
docs/rules/aws_security_group_egress_and_ingress_blocks_deprecated.md
Outdated
Show resolved
Hide resolved
docs/rules/aws_security_group_egress_and_ingress_blocks_deprecated.md
Outdated
Show resolved
Hide resolved
|
|
||
| Refrain from using the `ingress` and `egress` arguments of the `aws_security_group` resource for in-line rules, as they have difficulties managing multiple CIDR blocks and historically lack unique IDs, tags, and descriptions. To prevent these issues, follow the best practice of using the `aws_vpc_security_group_egress_rule` and `aws_vpc_security_group_ingress_rule` resources, with one CIDR block per rule. | ||
|
|
||
| Avoid using the `aws_security_group` resource with in-line rules (using the ingress and egress arguments) alongside the `aws_vpc_security_group_egress_rule`, `aws_vpc_security_group_ingress_rule`, or `aws_security_group_rule` resources. This practice can lead to rule conflicts, perpetual differences, and rules being overwritten. |
There was a problem hiding this comment.
These sentences appear to be copied from official references, but they feel a bit odd to include in this section.
Can you tidy up these sentences and rewrite them to explain why this rule is intended to disallow inline rules?
There was a problem hiding this comment.
Seems to be a duplication. Paragraph reworked.
rules/aws_security_group_egress_and_ingress_blocks_deprecated.go
Outdated
Show resolved
Hide resolved
rules/aws_security_group_egress_and_ingress_blocks_deprecated.go
Outdated
Show resolved
Hide resolved
kayman-mk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new rule to ensure that
ingressandegressblocks inaws_security_groupare not used.Avoid using the
ingressandegressarguments of theaws_security_groupresource to configure in-line rules, as they have difficulties managing multiple CIDR blocks and lack unique IDs, tags, and descriptions. To prevent these issues, follow the current best practice of using theaws_vpc_security_group_egress_ruleandaws_vpc_security_group_ingress_ruleresources, with one CIDR block per rule.Closes #419