Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to build with go1.24 #2239

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
- name: Run linters
uses: golangci/golangci-lint-action@ec5d18412c0aeab7936cb16880d708ba2a64e1ae # v6.2.0
with:
version: v1.62.2
version: v1.64.4
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM golang:1.23-alpine3.21 AS builder
FROM --platform=$BUILDPLATFORM golang:1.24-alpine3.21 AS builder

ARG TARGETOS TARGETARCH

Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide/building.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Building TFLint

Go 1.23 or higher is required to build TFLint from source code. Clone the source code and run the `make` command. Built binary will be placed in `dist` directory.
Go 1.24 or higher is required to build TFLint from source code. Clone the source code and run the `make` command. Built binary will be placed in `dist` directory.

```console
$ git clone https://github.com/terraform-linters/tflint.git
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/terraform-linters/tflint

go 1.23
go 1.24.0

require (
github.com/agext/levenshtein v1.2.3
Expand Down
2 changes: 1 addition & 1 deletion terraform/addrs/parse_ref_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ func TestParseRef(t *testing.T) {
}

for _, problem := range deep.Equal(got, test.Want) {
t.Errorf(problem)
t.Errorf("%s", problem)
}
})
}
Expand Down
2 changes: 1 addition & 1 deletion terraform/lang/funcs/collection.go
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ var SumFunc = function.New(&function.Spec{
ty := args[0].Type()

if !ty.IsListType() && !ty.IsSetType() && !ty.IsTupleType() {
return cty.NilVal, function.NewArgErrorf(0, fmt.Sprintf("argument must be list, set, or tuple. Received %s", ty.FriendlyName()))
return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple. Received %s", ty.FriendlyName())
}

if !args[0].IsWhollyKnown() {
Expand Down
2 changes: 1 addition & 1 deletion terraform/lang/funcs/crypto.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ var RsaDecryptFunc = function.New(&function.Spec{
default:
errStr = fmt.Sprintf("invalid private key: %s", e)
}
return cty.UnknownVal(cty.String), function.NewArgErrorf(1, errStr)
return cty.UnknownVal(cty.String), function.NewArgErrorf(1, "%s", errStr)
}
privateKey, ok := rawKey.(*rsa.PrivateKey)
if !ok {
Expand Down
Loading