Skip to content

chore: try to improve ci build times - #2199

Closed
mcalhoun wants to merge 1 commit into
mainfrom
mcalhoun/try-to-improve-ci-build-times
Closed

chore: try to improve ci build times#2199
mcalhoun wants to merge 1 commit into
mainfrom
mcalhoun/try-to-improve-ci-build-times

Conversation

@mcalhoun

@mcalhoun mcalhoun commented Sep 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR is an attempt to significantly improve CI/CD performance by implementing comprehensive caching and optimization strategies across all GitHub Actions workflows.

Key Improvements:

Performance Impact:

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no - this is an internal CI/CD optimization that improves developer experience through faster build times but doesn't change any user-facing functionality

@mcalhoun
mcalhoun requested a review from a team as a code owner September 7, 2025 00:41
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in b17865d

🔍 View Details on Terramate Cloud

.

@mcalhoun
mcalhoun force-pushed the mcalhoun/try-to-improve-ci-build-times branch from b17865d to 1f708b0 Compare September 7, 2025 00:57
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Sep 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 1f708b0

🔍 View Details on Terramate Cloud

.

@mcalhoun
mcalhoun force-pushed the mcalhoun/try-to-improve-ci-build-times branch from 1f708b0 to 8b71be4 Compare September 7, 2025 01:06
cursor[bot]

This comment was marked as outdated.

Sign in to view

@mcalhoun
mcalhoun force-pushed the mcalhoun/try-to-improve-ci-build-times branch from 8b71be4 to ed696ad Compare September 7, 2025 01:16
cursor[bot]

This comment was marked as outdated.

Sign in to view

@mcalhoun
mcalhoun force-pushed the mcalhoun/try-to-improve-ci-build-times branch from ed696ad to 6d90d66 Compare September 7, 2025 01:28
@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of ubuntu/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Preview of macos-ventura/go tests in 6d90d66

🔍 View Details on Terramate Cloud

.

@mcalhoun
mcalhoun force-pushed the mcalhoun/try-to-improve-ci-build-times branch from 6d90d66 to b29e11a Compare September 7, 2025 02:05
cursor[bot]
cursor Bot reviewed Sep 7, 2025
View reviewed changes
Comment thread makefiles/common.mk
go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)
@if ! command -v golangci-lint >/dev/null 2>&1 || ! golangci-lint version | grep -q "$(GOLANGCI_LINT_VERSION)"; then \
echo "Installing golangci-lint $(GOLANGCI_LINT_VERSION)..."; \
go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION); \

@cursor cursor Bot Sep 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Version Check Fails with Substring Matching

The version checks for cosign and golangci-lint use grep -q for substring matching. This can incorrectly detect installed versions, potentially skipping installation and leading to the wrong tool version being used in CI/release workflows.

Additional Locations (3)

Fix in Cursor Fix in Web

@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown 
toolsetPath: /tmp/cmd-terramate-test-3693894571
=== RUN   TestInteropCloudSyncPreview
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift
    interoperability_test.go:47: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
=== RUN   TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id
    interoperability_test.go:47: using GITHUB_EVENT_FILE=/home/runner/work/_temp/_github_workflow/event.json
--- PASS: TestInteropCloudSyncPreview (14.12s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift (7.43s)
    --- PASS: TestInteropCloudSyncPreview/preview:_basic-drift-uppercase-id (6.69s)
=== RUN   TestInteropSyncDeployment
=== RUN   TestInteropSyncDeployment/deployment:_empty
=== RUN   TestInteropSyncDeployment/deployment:_empty-uppercase-id
--- PASS: TestInteropSyncDeployment (43.24s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty (22.03s)
    --- PASS: TestInteropSyncDeployment/deployment:_empty-uppercase-id (21.21s)
=== RUN   TestInteropDrift
=== RUN   TestInteropDrift/drift:_basic-drift
=== RUN   TestInteropDrift/drift:_basic-drift-uppercase-id
--- PASS: TestInteropDrift (69.97s)
    --- PASS: TestInteropDrift/drift:_basic-drift (35.44s)
    --- PASS: TestInteropDrift/drift:_basic-drift-uppercase-id (34.53s)
PASS
ok  	github.com/terramate-io/terramate/e2etests/cloud/interop	199.020s

@mcalhoun mcalhoun closed this Sep 7, 2025
@mcalhoun
mcalhoun deleted the mcalhoun/try-to-improve-ci-build-times branch September 7, 2025 02:14
@github-actions

github-actions Bot commented Sep 7, 2025

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mcalhoun