Skip to content

fix: list(bundle) display summarization - #2387

Merged
snakster merged 1 commit into
mainfrom
snk-fix-bundle-list-display
Sep 7, 2026
Merged

snakster merged 1 commit into
mainfrom
snk-fix-bundle-list-display

Conversation

@snakster

@snakster snakster commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR aligns the way list of bundle entries are collapsed (i.e. <2 items>) with other list entries.

Does this PR introduce a user-facing change?

no

Note

Low Risk
Display-only change in the TUI completed-inputs summary; no data, evaluation, or persistence logic is touched.

Overview
Bundle reference lists in the completed-inputs panel no longer expand every alias into a comma-separated line. They now use the same summarization as other list(...) values: one entry still shows the bundle name (resolved object or key), while two or more show <N items> so long alias lists do not dominate the panel.

Implementation removes the list(bundle(...)) special case in formatCollectionDisplay and drops the unused strings import. Tests were renamed and broadened to cover empty, single, and multi-item bundle ref collections.

Reviewed by Cursor Bugbot for commit 9731eee. Bugbot is set up for automated code reviews on this repo. Configure here.

@snakster
snakster requested a review from a team as a code owner September 7, 2026 11:48
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Preview of ubuntu/go tests in 9731eee

🔍 View Details on Terramate Cloud

.
commands/ui

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
## Package: benchmarks/changed
metric: time/op
ChangeDetection-4: old 2.66ms ±12%: new 2.92ms ±11%: delta: 10.01%
ChangeDetectionTFAndTG-4: old 2.72ms ±22%: new 2.74ms ±12%: delta: 0.00%
metric: alloc/op
ChangeDetection-4: old 356kB ± 0%: new 356kB ± 0%: delta: 0.02%
ChangeDetectionTFAndTG-4: old 255kB ± 1%: new 255kB ± 1%: delta: 0.00%
metric: allocs/op
ChangeDetection-4: old 2.40k ± 0%: new 2.40k ± 0%: delta: 0.00%
ChangeDetectionTFAndTG-4: old 1.87k ± 4%: new 1.87k ± 3%: delta: 0.00%

---

## Package: cloud
metric: time/op
CloudReadLines-4: old 664µs ±12%: new 633µs ± 6%: delta: -4.67%
CloudReadLine-4: old 3.65ms ±19%: new 3.17ms ± 5%: delta: -13.29%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%

---

## Package: fs
metric: time/op
ListFiles-4: old 29.4µs ± 6%: new 28.8µs ± 8%: delta: 0.00%
metric: alloc/op
ListFiles-4: old 27.6kB ± 0%: new 27.6kB ± 0%: delta: 0.00%
metric: allocs/op
ListFiles-4: old 335 ± 0%: new 335 ± 0%: delta: 0.00%

---

## Package: generate
metric: time/op
Generate-4: old 674ms ± 7%: new 682ms ± 4%: delta: 0.00%
GenerateRegex-4: old 422ms ± 5%: new 421ms ± 4%: delta: 0.00%
metric: alloc/op
Generate-4: old 2.23GB ± 0%: new 2.23GB ± 0%: delta: 0.00%
GenerateRegex-4: old 922MB ± 0%: new 922MB ± 0%: delta: -0.01%
metric: allocs/op
Generate-4: old 25.7M ± 0%: new 25.7M ± 0%: delta: 0.00%
GenerateRegex-4: old 18.1M ± 0%: new 18.1M ± 0%: delta: 0.00%

---

## Package: hcl/ast
metric: time/op
TokensForExpressionComplex-4: old 910µs ± 9%: new 875µs ± 2%: delta: -3.91%
TokensForExpressionPlainStringNoNewline-4: old 366ns ± 7%: new 358ns ± 4%: delta: -2.11%
TokensForExpressionStringWith100Newlines-4: old 10.3µs ± 2%: new 11.1µs ± 4%: delta: 8.32%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.03ms ± 1%: new 1.01ms ± 3%: delta: -1.60%
TokensForExpression-4: old 873µs ± 6%: new 880µs ± 2%: delta: 0.00%
metric: alloc/op
TokensForExpressionComplex-4: old 393kB ± 0%: new 393kB ± 0%: delta: -0.00%
TokensForExpressionPlainStringNoNewline-4: old 512B ± 0%: new 512B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 12.5kB ± 0%: new 12.5kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 393kB ± 0%: new 393kB ± 0%: delta: -0.00%
TokensForExpression-4: old 393kB ± 0%: new 393kB ± 0%: delta: 0.00%
metric: allocs/op
TokensForExpressionComplex-4: old 4.75k ± 0%: new 4.75k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 227 ± 0%: new 227 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.09k ± 0%: new 3.09k ± 0%: delta: -0.01%
TokensForExpression-4: old 4.75k ± 0%: new 4.75k ± 0%: delta: 0.00%

---

## Package: hcl/eval
metric: time/op
PartialEvalComplex-4: old 322µs ±19%: new 333µs ± 8%: delta: 3.25%
PartialEvalSmallString-4: old 2.02µs ± 7%: new 2.10µs ± 5%: delta: 4.43%
PartialEvalHugeString-4: old 956µs ± 2%: new 965µs ± 2%: delta: 0.90%
PartialEvalHugeInterpolatedString-4: old 2.97ms ±28%: new 3.04ms ± 9%: delta: 0.00%
PartialEvalObject-4: old 15.0µs ±17%: new 15.1µs ±14%: delta: 0.00%
metric: alloc/op
PartialEvalComplex-4: old 360kB ± 0%: new 360kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.94kB ± 0%: new 1.94kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 196kB ± 0%: new 196kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.30MB ± 0%: new 4.30MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 19.4kB ± 0%: new 19.4kB ± 0%: delta: 0.00%
metric: allocs/op
PartialEvalComplex-4: old 3.72k ± 0%: new 3.72k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 25.0 ± 0%: new 25.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 38.0 ± 0%: new 38.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 25.1k ± 0%: new 25.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 179 ± 0%: new 179 ± 0%: delta: 0.00%

---

## Package: ls
metric: time/op
FindDefinition/10_files-4: old 14.6µs ±10%: new 15.0µs ±24%: delta: 0.00%
FindDefinition/50_files-4: old 23.3µs ±10%: new 23.0µs ±10%: delta: 0.00%
FindDefinition/100_files-4: old 31.1µs ± 7%: new 34.8µs ±13%: delta: 12.04%
FindDefinition/500_files-4: old 117µs ± 6%: new 121µs ± 5%: delta: 3.33%
FindReferences/10_files_5_refs-4: old 97.5µs ±14%: new 95.9µs ±10%: delta: 0.00%
FindReferences/50_files_10_refs-4: old 396µs ± 6%: new 355µs ±12%: delta: -10.17%
FindReferences/100_files_20_refs-4: old 688µs ±14%: new 702µs ±14%: delta: 0.00%
FindReferences/500_files_50_refs-4: old 3.90ms ±17%: new 3.59ms ±18%: delta: -8.11%
Rename/10_files_5_refs-4: old 123µs ± 8%: new 115µs ±14%: delta: -6.66%
Rename/50_files_10_refs-4: old 424µs ± 8%: new 366µs ± 8%: delta: -13.56%
Rename/100_files_20_refs-4: old 790µs ±11%: new 826µs ±16%: delta: 4.55%
SearchWorkspace/flat_100_files-4: old 744µs ± 7%: new 694µs ±14%: delta: -6.77%
SearchWorkspace/flat_500_files-4: old 3.88ms ±13%: new 3.61ms ±16%: delta: -6.78%
SearchWorkspace/nested_100_files_5_deep-4: old 676µs ± 8%: new 710µs ±15%: delta: 0.00%
SearchWorkspace/nested_500_files_5_deep-4: old 3.47ms ±12%: new 3.57ms ±15%: delta: 0.00%
ParseFile/small_file_10_lines-4: old 24.8µs ±13%: new 24.2µs ±11%: delta: 0.00%
ParseFile/medium_file_50_lines-4: old 106µs ±20%: new 104µs ±14%: delta: 0.00%
ParseFile/large_file_200_lines-4: old 427µs ±12%: new 427µs ±17%: delta: 0.00%
ParseFile/huge_file_1000_lines-4: old 2.16ms ±12%: new 2.01ms ±11%: delta: -7.04%
metric: alloc/op
FindDefinition/10_files-4: old 15.2kB ± 0%: new 15.2kB ± 0%: delta: 0.00%
FindDefinition/50_files-4: old 20.1kB ± 0%: new 20.1kB ± 0%: delta: 0.00%
FindDefinition/100_files-4: old 26.4kB ± 0%: new 26.4kB ± 0%: delta: 0.01%
FindDefinition/500_files-4: old 72.8kB ± 0%: new 72.8kB ± 0%: delta: 0.00%
FindReferences/10_files_5_refs-4: old 87.0kB ± 0%: new 87.0kB ± 0%: delta: -0.01%
FindReferences/50_files_10_refs-4: old 336kB ± 0%: new 336kB ± 0%: delta: -0.03%
FindReferences/100_files_20_refs-4: old 646kB ± 0%: new 646kB ± 0%: delta: 0.00%
FindReferences/500_files_50_refs-4: old 3.13MB ± 0%: new 3.13MB ± 0%: delta: -0.01%
Rename/10_files_5_refs-4: old 105kB ± 0%: new 105kB ± 0%: delta: 0.00%
Rename/50_files_10_refs-4: old 359kB ± 0%: new 359kB ± 0%: delta: 0.00%
Rename/100_files_20_refs-4: old 677kB ± 0%: new 677kB ± 0%: delta: 0.01%
SearchWorkspace/flat_100_files-4: old 628kB ± 0%: new 628kB ± 0%: delta: 0.00%
SearchWorkspace/flat_500_files-4: old 3.09MB ± 0%: new 3.09MB ± 0%: delta: 0.00%
SearchWorkspace/nested_100_files_5_deep-4: old 636kB ± 0%: new 636kB ± 0%: delta: 0.00%
SearchWorkspace/nested_500_files_5_deep-4: old 3.13MB ± 0%: new 3.13MB ± 0%: delta: 0.04%
ParseFile/small_file_10_lines-4: old 34.7kB ± 0%: new 34.7kB ± 0%: delta: 0.00%
ParseFile/medium_file_50_lines-4: old 151kB ± 0%: new 151kB ± 0%: delta: 0.00%
ParseFile/large_file_200_lines-4: old 733kB ± 0%: new 733kB ± 0%: delta: 0.00%
ParseFile/huge_file_1000_lines-4: old 4.06MB ± 0%: new 4.06MB ± 0%: delta: -0.00%
metric: allocs/op
FindDefinition/10_files-4: old 209 ± 0%: new 209 ± 0%: delta: 0.00%
FindDefinition/50_files-4: old 291 ± 0%: new 291 ± 0%: delta: 0.00%
FindDefinition/100_files-4: old 392 ± 0%: new 392 ± 0%: delta: 0.00%
FindDefinition/500_files-4: old 1.19k ± 0%: new 1.19k ± 0%: delta: 0.00%
FindReferences/10_files_5_refs-4: old 960 ± 0%: new 960 ± 0%: delta: 0.00%
FindReferences/50_files_10_refs-4: old 3.81k ± 0%: new 3.81k ± 0%: delta: 0.00%
FindReferences/100_files_20_refs-4: old 7.34k ± 0%: new 7.34k ± 0%: delta: 0.00%
FindReferences/500_files_50_refs-4: old 35.9k ± 0%: new 35.9k ± 0%: delta: 0.00%
Rename/10_files_5_refs-4: old 1.15k ± 0%: new 1.15k ± 0%: delta: 0.00%
Rename/50_files_10_refs-4: old 4.09k ± 0%: new 4.09k ± 0%: delta: 0.00%
Rename/100_files_20_refs-4: old 7.74k ± 0%: new 7.74k ± 0%: delta: 0.00%
SearchWorkspace/flat_100_files-4: old 7.13k ± 0%: new 7.13k ± 0%: delta: 0.00%
SearchWorkspace/flat_500_files-4: old 35.1k ± 0%: new 35.1k ± 0%: delta: 0.00%
SearchWorkspace/nested_100_files_5_deep-4: old 7.18k ± 0%: new 7.18k ± 0%: delta: 0.00%
SearchWorkspace/nested_500_files_5_deep-4: old 35.2k ± 0%: new 35.2k ± 0%: delta: 0.00%
ParseFile/small_file_10_lines-4: old 315 ± 0%: new 315 ± 0%: delta: 0.00%
ParseFile/medium_file_50_lines-4: old 1.39k ± 0%: new 1.39k ± 0%: delta: 0.00%
ParseFile/large_file_200_lines-4: old 5.46k ± 0%: new 5.46k ± 0%: delta: 0.00%
ParseFile/huge_file_1000_lines-4: old 26.2k ± 0%: new 26.2k ± 0%: delta: 0.00%

---

## Package: stdlib
metric: time/op
TmAllTrueLiteralList-4: old 288µs ± 6%: new 267µs ±10%: delta: -7.36%
TmAllTrueFuncall-4: old 8.88µs ± 9%: new 8.45µs ± 8%: delta: -4.85%
TmAnyTrueLiteralList-4: old 2.05ms ± 4%: new 2.02ms ± 7%: delta: 0.00%
TmAnyTrueFuncall-4: old 9.35µs ± 6%: new 8.92µs ± 9%: delta: -4.67%
TmTernary-4: old 1.09µs ± 7%: new 1.07µs ± 7%: delta: 0.00%
TmTryUnknownFunc-4: old 1.01µs ± 8%: new 0.98µs ± 8%: delta: -3.07%
TmTryUnknownVariable-4: old 967ns ± 7%: new 995ns ± 4%: delta: 2.93%
TmTryUnknownObjectKey-4: old 1.12µs ± 4%: new 1.15µs ±10%: delta: 3.09%
SlugifyLargeList-4: old 1.09ms ± 4%: new 1.07ms ± 7%: delta: 0.00%
metric: alloc/op
TmAllTrueLiteralList-4: old 320kB ± 0%: new 320kB ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 10.4kB ± 0%: new 10.4kB ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 2.09MB ± 0%: new 2.09MB ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 10.5kB ± 0%: new 10.5kB ± 0%: delta: 0.00%
TmTernary-4: old 1.18kB ± 0%: new 1.18kB ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 784B ± 0%: new 784B ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 768B ± 0%: new 768B ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 952B ± 0%: new 952B ± 0%: delta: 0.00%
SlugifyLargeList-4: old 614kB ± 0%: new 614kB ± 0%: delta: 0.00%
metric: allocs/op
TmAllTrueLiteralList-4: old 5.93k ± 0%: new 5.93k ± 0%: delta: 0.00%
TmAllTrueFuncall-4: old 265 ± 0%: new 265 ± 0%: delta: 0.00%
TmAnyTrueLiteralList-4: old 59.6k ± 0%: new 59.6k ± 0%: delta: 0.00%
TmAnyTrueFuncall-4: old 267 ± 0%: new 267 ± 0%: delta: 0.00%
TmTernary-4: old 27.0 ± 0%: new 27.0 ± 0%: delta: 0.00%
TmTryUnknownFunc-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TmTryUnknownVariable-4: old 20.0 ± 0%: new 20.0 ± 0%: delta: 0.00%
TmTryUnknownObjectKey-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
SlugifyLargeList-4: old 18.0k ± 0%: new 18.0k ± 0%: delta: 0.00%

---

## Package: tg
metric: time/op
ModuleDiscovery-4: old 31.0ms ± 6%: new 30.1ms ±13%: delta: -2.91%
metric: alloc/op
ModuleDiscovery-4: old 36.9MB ± 0%: new 36.9MB ± 0%: delta: 0.04%
metric: allocs/op
ModuleDiscovery-4: old 455k ± 0%: new 455k ± 0%: delta: 0.00%

---

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Preview of macos-15/go tests in 9731eee

🔍 View Details on Terramate Cloud

.
commands/ui

@snakster
snakster merged commit 3fbf2fe into main Sep 7, 2026
18 checks passed
@snakster
snakster deleted the snk-fix-bundle-list-display branch September 7, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant