Merge pull request #79 from sobolevn/patch-4

Refactors `hasattr` + `except: pass` to a single `getattr`
terrencepreilly · Apr 9, 2020 · a3e19cf · a3e19cf
2 parents c3de7bc + e9e1db7
commit a3e19cf
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/darglint/analysis/raise_visitor.py b/darglint/analysis/raise_visitor.py
@@ -134,13 +134,9 @@ def visit_Try(self, node):
             if handler.type:
                 if handler.name and isinstance(handler.type, ast.Name):
                     self.context.add_variable(handler.name, handler.type)
-                if hasattr(handler.type, 'id'):
-                    id = getattr(handler.type, 'id')
-                    if id:
-                        self.context.remove_exception(id)
-                else:
-                    # TODO: What is this?  Only in 3.8?
-                    pass
+                id = getattr(handler.type, 'id', None)
+                if id:
+                    self.context.remove_exception(id)
             else:
                 self.context.remove_all_exceptions()
         for handler in node.handlers: