feat: Allow canceling container start in xUnit.net v3 fixtures #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This passes
TestContext.Current.CancellationTokentoContainer.StartAsync, so that cancelling a test-session may cancel starting the requested TestcontainerWhy is it important?
If the test-session is already set to cancelled, the fixture is likely disposed, just after being started, without being used by any test. Waiting for the start waists time and resources.
How to test this PR
Start any test utilizing
Testcontainers.XunitV3, and cancel test-execution during container creation/startup. It should cancel quickly, reporting a TaskCancelledException to the test starting up