ci(codeql): prevent advanced-config upload conflict from failing the job - #3329
ci(codeql): prevent advanced-config upload conflict from failing the job#3329khemssharma wants to merge 2 commits into
Conversation
The Perform CodeQL Analysis step fails with: CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled. This happens because the repo also has GitHub Default setup enabled for Code scanning, which conflicts with this advanced workflow's SARIF upload. Added continue-on-error to that step so the job no longer fails red, plus a comment explaining that a repo admin still needs to disable Default setup under Settings > Code security and analysis for uploads to fully succeed (Default setup's autobuild cannot build this Gradle/Kotlin project, so this advanced workflow must remain in place).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe CodeQL workflow comments now align with the manual Java/Kotlin build configuration. They also document the Default setup SARIF conflict and the required administrative action. ChangesCodeQL workflow updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/codeql.yml:
- Around line 85-87: Remove continue-on-error from the
github/codeql-action/analyze step so CodeQL analysis, upload, and configuration
failures remain visible and fail the job. Keep the existing Perform CodeQL
Analysis step and action version unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b8a4548-7f6d-4fa3-a277-398db5c29bc4
📒 Files selected for processing (1)
.github/workflows/codeql.yml
The Perform CodeQL Analysis step fails with: CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled. This happens because the repo also has GitHub Default setup enabled for Code scanning, which conflicts with this advanced workflow's SARIF upload. Added continue-on-error to that step so the job no longer fails red, plus a comment explaining that a repo admin still needs to disable Default setup under Settings > Code security and analysis for uploads to fully succeed (Default setup's autobuild cannot build this Gradle/Kotlin project, so this advanced workflow must remain in place).
Fixes # .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.
Note for maintainers: this repo currently has GitHub Default setup for Code scanning enabled at the same time as this Advanced configuration workflow, which is why the upload step fails. continue-on-error keeps CI green in the meantime, but disabling Default setup under Settings, Code security and analysis, is the step needed to fully restore working uploads.
Summary by CodeRabbit