show 'cargo-expand' errors when testing an exercise#60
Open
Yehuda-blip wants to merge 1 commit into
Open
Conversation
|
potentially related to #59 ? |
Author
|
As far as I can tell, the issues are not related. In order to initially build the crate I followed the instructions in #59, (remove lock and build) - this solved the build issue. However, I did not have cargo-expand installed and this led to empty diffs with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I started going through the repo, It seems this is gonna be a great way for me to learn about macros!
When I tried to run the testing for the first exercise, the diff output was empty. I tried to deliberately fail the exercise but the diff was still empty, and I got a success result printed. Some debugging later it seems I skipped the "install cargo-expand" instruction in the readme. This PR just checks that the expand command ran successfully before printing results.
Steps to reproduce the problem:
The diff should be empty, both when expecting success and both when expecting failure.