Skip to content

fix(issue #49): rg.get allows for integer coordinates and provides better feedback in TypeError #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allenlawrence94 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(issue #49): rg.get allows for integer coordinates and provides better feedback in TypeError #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,8 @@ cmake_install.cmake
CMakeCache.txt
main
Makefile
libreverse_geocode.a
libreverse_geocode.a

# IDE related files #
#####################
.idea
4 changes: 2 additions & 2 deletions reverse_geocoder/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,8 @@ def get(geo_coord, mode=2, verbose=True):
"""
Function to query for a single coordinate
"""
if not isinstance(geo_coord, tuple) or not isinstance(geo_coord[0], float):
raise TypeError('Expecting a tuple')
if not isinstance(geo_coord, tuple) or not all(isinstance(c, (float, int)) for c in geo_coord):
raise TypeError('Expecting a tuple of floats or ints')

_rg = RGeocoder(mode=mode, verbose=verbose)
return _rg.query([geo_coord])[0]
Expand Down