Dev/younes main #15
Merged
Dev/younes main #15
+445
−430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several UI and functionality improvements across the app including a new NoNotification icon component, updates to screen layouts and navigation, and enhancements to calendar and booking features. Key changes include:
- New and updated components for notifications, profile, and calendar with improved UI elements.
- Adjustments to navigation routes and header titles across multiple screens.
- Code refactoring in hooks and type definitions along with removal of deprecated screens.
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| client/components/icons/NoNotification.tsx | Added a new SVG icon component for no notifications |
| client/app/notifications.tsx | Integrated the NoNotification icon and updated empty state UI |
| client/app/_layout.tsx | Updated header titles and removed header styling for some screens |
| client/constants/types.ts | Reformatted type declarations for consistency |
| client/app/(tabs)/profile.tsx | Updated profile header to use currentUser properties |
| client/components/ui/ActivityDetailsPopup.tsx | Adjusted layout spacing using gap classes |
| client/app/(tabs)/_layout.tsx | Revised tab icon colors and active/inactive tint settings |
| client/hooks/useAuth.ts | Added toggleNotification and toggleGamification callbacks |
| client/components/ui/BookingOptions.tsx | Fixed navigation calls by removing casts |
| client/components/SettingsSection.tsx | Updated toggle buttons to use new auth hooks |
| client/app/(tabs)/index.tsx | Added keys for list items and updated texts in the home screen |
| client/components/BookingSlotModal.tsx | Updated Calendar theme configuration |
| client/app/nutrition.tsx | Added flex styling to the container for better layout |
| client/app/(tabs)/membership.tsx | Cleaned up membership display and removed unnecessary whitespace |
| client/app/training.tsx | Changed price types and updated description text casing |
| client/components/ui/CalendarComponent.tsx | Enhanced event-to-dot mapping and improved legend rendering |
| client/app/NutritionConsultancy.tsx & client/app/OnlineActivity.tsx | Removed deprecated screens |
Files not reviewed (1)
- client/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
client/app/(tabs)/membership.tsx:198
- The function name 'MmeberhipPage' appears to be misspelled; consider renaming it to 'MembershipPage'.
export default function MmeberhipPage() {
client/app/notifications.tsx
Outdated
| </View> | ||
| <View className="flex flex-col items-center justify-center mt-[70px]"> | ||
| <Text className="text-red font-bold text-2xl"> | ||
| There's no notifications |
There was a problem hiding this comment.
The text "There's no notifications" is grammatically incorrect; consider replacing it with "There are no notifications".
Suggested change
| There's no notifications | |
| There are no notifications |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
client/app/(tabs)/index.tsx
Outdated
| @@ -107,7 +108,7 @@ export default function HomeScreen() { | |||
| <View style={styles.qrTextContainer}> | |||
| <Text style={styles.qrText}>Gym Check-in</Text> | |||
| <Text style={styles.qrsubText}> | |||
| Tap to here scan qr code | |||
| Tap to here scan QR code | |||
There was a problem hiding this comment.
[nitpick] The instruction 'Tap to here scan QR code' seems awkward; consider rewording it to 'Tap here to scan QR code'.
Suggested change
| Tap to here scan QR code | |
| Tap here to scan QR code |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…into dev/younes_main
…into dev/younes_main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.