Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Translations #179

Merged
merged 21 commits into from
Aug 3, 2022
Merged

French Translations #179

merged 21 commits into from
Aug 3, 2022

Conversation

neelakantan-ca
Copy link
Contributor

French Translations

As per issue #175 added a French translation.

@neelakantan-ca neelakantan-ca requested a review from a team as a code owner August 1, 2022 00:22
Shebuka
Shebuka previously requested changes Aug 1, 2022
Copy link
Contributor

@Shebuka Shebuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked some of the static text with how it translated in the game by setting the language to French.
Can you please review the changes and adapt any other places I didn't catch?

src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Outdated Show resolved Hide resolved
src/translations/fr/translation.json Show resolved Hide resolved
@GrantBirki GrantBirki added the language Changes related to wording on the site or translations label Aug 1, 2022
@GrantBirki
Copy link
Member

.deploy to development

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Deployment Triggered

GrantBirki, started a branch deployment 🚀

  • Branch: fec3e7ca9c7b7f272922c859829ad91d6a481c6c
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to development August 1, 2022 18:04 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: fec3e7ca9c7b7f272922c859829ad91d6a481c6c

Successfully deployed branch fec3e7c

Actor: GrantBirki, Action: issue_comment, Workflow: branch-deploy

@GrantBirki
Copy link
Member

@Cantej I won't merge or deploy to production yet as there are still outstanding suggestions on this PR, but I went ahead and deployed to our dev env so you can check it out!

https://ad33beb8.tarkov-dev.pages.dev/ 🔗

@neelakantan-ca
Copy link
Contributor Author

I've checked some of the static text with how it translated in the game by setting the language to French. Can you please review the changes and adapt any other places I didn't catch?

Hey,

Sorry for the late response, life has been a bit hectic

Yea sure will go through the changes soon.

Can you please review the changes and adapt any other places I didn't catch?

In regards to places you didn't catch, I don't actually play Escape from Tarkov, so I won't be able to fix those.

I just saw this issue as something I could do with my basic understanding of French and decided to help out.

neelakantan-ca and others added 15 commits August 3, 2022 07:24
@neelakantan-ca
Copy link
Contributor Author

Well I have gone through all the suggestions and made the required changes. For a few of them, I am unsure let me know what you would like me to do with them.

Is there anything else I need to do ?

@GrantBirki GrantBirki dismissed Shebuka’s stale review August 3, 2022 04:27

looks like 99% is resolved now

@GrantBirki
Copy link
Member

@Cantej I went ahead and resolved the outstanding comments. You moved the needle enough in the right direction with most of them so I think its okay and we can always iterate in a PR later on.

Thank you so much for you assistance with the French translations!

@GrantBirki
Copy link
Member

.deploy

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Deployment Triggered

GrantBirki, started a branch deployment 🚀

  • Branch: 3ab2297cf56fb74faa66c308d92705146fda902e
  • Mode: branch

You can watch the progress here 🔗

@github-actions github-actions bot temporarily deployed to production August 3, 2022 04:29 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Deployment Results

  • Status: success ✔️
  • Mode: branch 🚀
  • Branch: 3ab2297cf56fb74faa66c308d92705146fda902e

Successfully deployed branch 3ab2297

Actor: GrantBirki, Action: issue_comment, Workflow: branch-deploy

@GrantBirki GrantBirki merged commit 9af68ca into the-hideout:main Aug 3, 2022
@neelakantan-ca
Copy link
Contributor Author

@GrantBirki Thank you so much for the opportunity to work on this, this was a wonderful experience

@neelakantan-ca
Copy link
Contributor Author

Hey,

Is it okay to delete the fork I made or does that break something ?

@Shebuka
Copy link
Contributor

Shebuka commented Aug 3, 2022

Thank you for the contribution, really appreciate 👍

Hey,

Is it okay to delete the fork I made or does that break something ?

You can safely delete your fork ;)

@Shebuka
Copy link
Contributor

Shebuka commented Feb 9, 2023

Hey @Cantej 👋

We have dome some major updates to our localizations 🌐 and it will be great if you can help us with the translation 🇫🇷 again #175.

The easiest way is to join our translation project in POEditor with this link https://poeditor.com/join/project/YA8ZrCsxTi 👍 or create a PR on this translation file https://github.com/the-hideout/tarkov-dev/blob/main/src/translations/fr/translation.json as you've done here and translate new properties.json and bosses.json by copying them from en folder 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language Changes related to wording on the site or translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants