-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French Translations #179
French Translations #179
Conversation
As per Issue #175
Updated French Translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked some of the static text with how it translated in the game by setting the language to French.
Can you please review the changes and adapt any other places I didn't catch?
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
.deploy to development |
Deployment TriggeredGrantBirki, started a branch deployment 🚀
You can watch the progress here 🔗 |
Deployment Results
Successfully deployed branch fec3e7c
|
@Cantej I won't merge or deploy to production yet as there are still outstanding suggestions on this PR, but I went ahead and deployed to our dev env so you can check it out! |
Hey, Sorry for the late response, life has been a bit hectic Yea sure will go through the changes soon.
In regards to places you didn't catch, I don't actually play Escape from Tarkov, so I won't be able to fix those. I just saw this issue as something I could do with my basic understanding of French and decided to help out. |
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Co-authored-by: Anton Shebukov <[email protected]>
Well I have gone through all the suggestions and made the required changes. For a few of them, I am unsure let me know what you would like me to do with them. Is there anything else I need to do ? |
Co-authored-by: Cantej <[email protected]>
@Cantej I went ahead and resolved the outstanding comments. You moved the needle enough in the right direction with most of them so I think its okay and we can always iterate in a PR later on. Thank you so much for you assistance with the French translations! |
.deploy |
Deployment TriggeredGrantBirki, started a branch deployment 🚀
You can watch the progress here 🔗 |
Deployment Results
Successfully deployed branch 3ab2297
|
@GrantBirki Thank you so much for the opportunity to work on this, this was a wonderful experience |
Hey, Is it okay to delete the fork I made or does that break something ? |
Thank you for the contribution, really appreciate 👍
You can safely delete your fork ;) |
Hey @Cantej 👋 We have dome some major updates to our localizations 🌐 and it will be great if you can help us with the translation 🇫🇷 again #175. The easiest way is to join our translation project in POEditor with this link https://poeditor.com/join/project/YA8ZrCsxTi 👍 or create a PR on this translation file https://github.com/the-hideout/tarkov-dev/blob/main/src/translations/fr/translation.json as you've done here and translate new |
French Translations
As per issue #175 added a French translation.