Linux: Refine connection status reporting. #1389
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CAN and a few tunnel interface varieties to the list of ARP hardware types that do not have a connections status, and instead of skipping these types set PCAP_IF_CONNECTION_STATUS_NOT_APPLICABLE. For other types that fail SIOCETHTOOL with specific error codes set PCAP_IF_CONNECTION_STATUS_UNKNOWN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a disputable change because the new behaviour improves reporting of some interface types, but has potential for making reporting of other types worse. The reason for that is that many logical interfaces pretend to be Ethernet. Perhaps it will be easier to understand the best course of action after studying at various examples.
Let's make this a draft for now.