PTP: Refine timestamp printing. #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxlb
reviewed
Jan 9, 2025
infrastation
force-pushed
the
ptp_timestamp
branch
from
2386101 to
b518465
Compare
|
The next revision makes the code style more consistent and fixes one other bug. |
In ptp_print_timestamp_identity() and ptp_print_announce_msg() use ptp_print_timestamp() to deduplicate code. In ptp_print_timestamp() change the format to SECONDS.NANOSECONDS and indicate an invalid nanoseconds value. Update the tests. This resolves GH issue the-tcpdump-group#1260.
infrastation
force-pushed
the
ptp_timestamp
branch
from
b518465 to
94675fc
Compare
|
Simplified the matter a bit. This will be merged in one day unless anyone objects. |
|
The option for |
|
There is an authoritative source for that. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1260.