This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Updated to Swift 4, removed some unnecessary code and cleaned the example project #5
+94
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@startupthekid Any progress? |
|
I honestly did not see this until right now... |
|
Huh well I couldn't find out how to turn on notifs for new issues/PRs but I'll figure that out later. I really didn't even know people used this repository; I came really close to completely deleting it about a month ago. This PR looks good; unfortunately I made this repo when I was a really green engineer, so no tests or anything. I'm not even sure this is the best way to solve the problem because it involves overriding well-defined behavior. I'll merge this PR since it can't hurt but I'll try to think of a better to solve this over the next few days. |
|
Actually one quick thing @dejanskledar, if you wouldn't mind updating the README as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.