put keyword param names in backticks #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: please ignore the whitespace, not sure how/why but i have something running on my machine which is making these changes that i can't undo (unless i edit with notepad). they are technically correct, so going to just leave them in.
In the
Files Changed
tab click on the little ⚙️ icon and select "Hide Whitespace"Description
we currently only put property names in backticks. this puts param names in backticks as well
majority of complexity comes from the fact that a lot of times we create local parameters prefixed with an
_
, for example:Changes
helpers.h
for creating the local parameter name, via removing the backticks if neededcode_writers.h
:write_convert_to_abi_arg
write_local_param_wrappers
:Fixes WIN-896