Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix writing composable impl for generic default interfaces #127

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

stevenbrix
Copy link
Collaborator

@stevenbrix stevenbrix commented Dec 5, 2023

for composable classes with generic default interfaces, we were incorrectly writing type names like IVector<Foo>, which aren't valid swift type names. This uses the same bind_type_abi method we use for removing the brackets and writing a name like IVectorFoo instead.

This error didn't manifest itself until trying to use the ThemeShadow class which resulted in UIWeakElementCollection being generated, which is unsealed.

Changes

  1. description above
  2. Had to change typealias SwiftABI = IVectorFoo to the full name since there is a naming collision now
  3. updated one of the class definitions to be unsealed to verify the fix works

Fixes WIN-1015

@stevenbrix stevenbrix requested a review from a team as a code owner December 5, 2023 21:28
@stevenbrix stevenbrix merged commit d417360 into main Dec 6, 2023
1 check passed
@stevenbrix stevenbrix deleted the steve/fix-composable-generic-default branch December 6, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants