fix writing composable impl for generic default interfaces #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for composable classes with generic default interfaces, we were incorrectly writing type names like
IVector<Foo>
, which aren't valid swift type names. This uses the samebind_type_abi
method we use for removing the brackets and writing a name likeIVectorFoo
instead.This error didn't manifest itself until trying to use the
ThemeShadow
class which resulted inUIWeakElementCollection
being generated, which is unsealed.Changes
typealias SwiftABI = IVectorFoo
to the full name since there is a naming collision nowFixes WIN-1015