Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix uuid name #135

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix uuid name #135

merged 1 commit into from
Jan 19, 2024

Conversation

stevenbrix
Copy link
Collaborator

@stevenbrix stevenbrix commented Jan 19, 2024 •
edited
Loading

in #134 I missed a case in type_writers.cpp where we were no longer writing the full GUID name.

also added some cleaning up around checking for the GUID type so things aren't done by string checking which was broken inadvertently

@stevenbrix stevenbrix requested a review from a team as a code owner January 19, 2024 01:40
jumhyn-browser
jumhyn-browser approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@jumhyn-browser jumhyn-browser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@stevenbrix stevenbrix merged commit e6b363b into main Jan 19, 2024
1 check passed
@stevenbrix stevenbrix deleted the steve/fix-uuid-name-in-iterable branch January 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumhyn-browser jumhyn-browser jumhyn-browser approved these changes

@jeffdav jeffdav Awaiting requested review from jeffdav

@tristanlabelle tristanlabelle Awaiting requested review from tristanlabelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenbrix @jumhyn-browser