Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache factories and use fast pass strings #142

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

stevenbrix
Copy link
Collaborator

This PR caches default activation factories and also converts us from using String and allocating HSTRING to just using fast-pass string references to avoid unnecessary string allocations

@stevenbrix stevenbrix requested a review from a team as a code owner February 29, 2024 22:30
Copy link
Contributor

@jeffdav jeffdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ :shipit:

Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you see a path to using fast pass strings in normal API calls as well?

@stevenbrix
Copy link
Collaborator Author

Nice! Do you see a path to using fast pass strings in normal API calls as well?

yes, i want to spend a few hours improving the way we make abi calls so that we don't do this anymore:

let abi = wrapper.toAbi { $0 }

and instead do something like

AbiHelper.toAbi(thing1, thing2) { thing1Abi, thing2Abi in 

   doAbiCall(thing1Abi, thing2Abi);
}

@stevenbrix stevenbrix merged commit 499c448 into main Mar 1, 2024
2 checks passed
@stevenbrix stevenbrix deleted the steve/cache-factories branch March 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants