Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inner loop by removing clang #156

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix inner loop by removing clang #156

merged 2 commits into from
Apr 8, 2024

Conversation

stevenbrix
Copy link
Collaborator

@stevenbrix stevenbrix commented Apr 8, 2024

swift-winrt cant build using clang and #151 also breaks building it in Visual Studio as well as inner-loop for folks trying to debug in VSCode. since the test app is built using SPM, specifying clang doesn't do anything so we should be able to remove it entirely

@stevenbrix stevenbrix requested a review from a team as a code owner April 8, 2024 21:57
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this to unblock stuff, but @tristanlabelle is probably best suited to go over this.

Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is pretty confusing - what is the inner loop here? I see no induction in the code.

@stevenbrix stevenbrix merged commit c59c844 into main Apr 8, 2024
1 check passed
@stevenbrix stevenbrix deleted the steve/fix-inner-loop branch April 8, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants