Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Windows SDK id in installation instructions #195

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix Windows SDK id in installation instructions #195

merged 1 commit into from
Dec 19, 2024

Conversation

ktraunmueller
Copy link
Contributor

No description provided.

@ktraunmueller ktraunmueller requested a review from a team as a code owner December 19, 2024 12:06
@ktraunmueller ktraunmueller mentioned this pull request Dec 19, 2024
Closed
compnerd
compnerd approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@compnerd compnerd enabled auto-merge December 19, 2024 17:24
@compnerd compnerd merged commit f8b75d2 into thebrowsercompany:main Dec 19, 2024
1 check passed
@ktraunmueller
Copy link
Contributor Author

@compnerd Saleem FYI @tristanlabelle also created a pull request for the same issue.

@compnerd
Copy link
Contributor

Thanks @ktraunmueller - I saw that later. I think that we should be able to resolve the conflicts (if any) and get both merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktraunmueller @compnerd