fix: lantern placement issues, crashes and hanging sign #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sui-ke wants to merge 1 commit into thedarkcolour:main from sui-ke:lantern-fix

sui-ke commented May 17, 2025

What's fixed

Crashes: Prevent lantern placement on End Portal Frames to avoid IllegalArgumentException.
Slab Placement: Fix incorrect placement on bottom half slabs.
Hanging Stability: Add hanging_sign detection to prevent lantern drops during block updates.

Implementation Details

Added BlockEndPortalFrame check in isValidPos
Enforced slab HALF property validation
Integrated registry name detection for hanging_sign compatibility

Notes

The hanging_sign support specifically targets my 1.12.2 backported implementation from later versions (via Cherry), but can be safely removed if undesired.


          fix: lantern placement issues and hanging sign crashes

2c53a56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet