Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #77

Merged
merged 1 commit into from
Jan 27, 2019
Merged

fix typo #77

merged 1 commit into from
Jan 27, 2019

Conversation

bert-packed
Copy link
Contributor

@bert-packed bert-packed commented Jan 24, 2019

een haakje

Description

Fixing a link on the readme file

Motivation and context

The link didn't work...

If it fixes an open issue, please link to the issue here (if you write fixes #num
or closes #num, the issue will be automatically closed when the pull is accepted.)

no

How has this been tested?

I checked the readme. Hurray!

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

using my Dell XPS, rubbing Ubuntu 16.4 and Firefox

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • [ x] I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • [ x] Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

een haakje
@netsensei netsensei merged commit d1d04d7 into thedatahub:master Jan 27, 2019
@netsensei
Copy link
Contributor

Thanks! I've rebased and merged the contribution. You should do a "git pull" to get the latest changes in your local copy.

See also: #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants