Skip to content

Conversation

@ogajduse
Copy link
Member

This introduces a streamlined workflow for adding new Foreman versions:

  • Add Makefile with targets for downloading, setup, and cleanup
  • Create scripts/foreman-download.sh to fetch apidoc artifacts from GitHub Actions
  • Create scripts/foreman-setup.sh to set up directory structure and update index.html
  • Move cleanup.sh to scripts/ directory for better organization
  • Update README.md with simplified Makefile-based instructions

Usage: make foreman-add-version VERSION=X.Y

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

@ogajduse ogajduse requested a review from evgeni November 18, 2025 13:41
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a complete review

cp -r "$APIDOC_DIR"/* "foreman/$VERSION/apidoc/"

echo "Updating index.html..."
sed -i "/\.\/foreman\/latest\/apidoc\/v2\.html\">latest<\/a><\/li>/a\\\\t\\t<li><a href=\".\/foreman\/$VERSION\/apidoc\/v2.html\">$VERSION<\/a><\/li>" index.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use other separators (like | to avoid the escaping of /

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, changed

This introduces a streamlined workflow for adding new Foreman versions:
- Add Makefile with targets for downloading, setup, and cleanup
- Create scripts/foreman-download.sh to fetch apidoc artifacts from GitHub Actions
- Create scripts/foreman-setup.sh to set up directory structure and update index.html
- Move cleanup.sh to scripts/ directory for better organization
- Update README.md with simplified Makefile-based instructions

Usage: make foreman-add-version VERSION=X.Y

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants