Skip to content

Conversation

@Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Apr 8, 2024

When I was working on #2951 , I noticed that those modules were missing useful info.
Adding and tested in Satellite 6.15.
The feature has been available since Satellite 6.12 (~ Foreman 3.3).

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

@Lennonka Lennonka force-pushed the improve-playbook-import branch from 92daf55 to ed6c3cb Compare April 8, 2024 18:46
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestions. 👍 for adding the paths!

@Lennonka
Copy link
Contributor Author

Lennonka commented Apr 9, 2024

Good to go?

@Lennonka
Copy link
Contributor Author

Lennonka commented Apr 11, 2024

I'm assuming there are no further comments style wise. And it works for me :)))

@Lennonka Lennonka merged commit 5dad30c into theforeman:master Apr 11, 2024
@Lennonka
Copy link
Contributor Author

Cherry-picked:

@Lennonka Lennonka deleted the improve-playbook-import branch April 11, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants